518935 - Allow empty option in select boxes for AAQ form

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task)

Description

[[:Cww]]

Right now, we can't have a <empty> default option in the new ask a question form.

Comment 1

[James Socol [:jsocol, :james]]

Should this also involve warning if the empty option is still chosen?

Comment 2

[James Socol [:jsocol, :james]]

Attachment: PHP patch, v1

This patch allows you to put "<empty>" into the "options" box and generate an empty option. Place it first for the empty option to be the default.

Caveats: You can only have one empty line--from the description in comment 0, I think this is OK. This patch doesn't add validation from the JavaScript side. If that's necessary, it shouldn't be too difficult, but we'll need a way to describe which fields were left blank.

Comment 3

[Paul Craciunoiu [:paulc]]

Comment on attachment 405942 [details] [diff] [review]
PHP patch, v1

WFM. Will we need some SQL run to drop a key, on stage/prod?

Comment 4

[James Socol [:jsocol, :james]]

(In reply to comment #3)
> Will we need some SQL run to drop a key, on stage/prod?

I can't see why, this just allows a new value to be encoded in the serialized array stored in tiki_question_fields.options.

Comment 5

[James Socol [:jsocol, :james]]

r53431

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Cheng, mind giving this a whirl on staging?

Comment 7

[Paul Craciunoiu [:paulc]]

Wasn't this landed in 1.4.1?

Comment 8

[Paul Craciunoiu [:paulc]]

(In reply to comment #7)
> Wasn't this landed in 1.4.1?
Nevermind. It's trunk only :)

Comment 9

[[:Cww]]

Functionality works, it'd be nice to have instructions on the admin page though so it's clearer how this works.

Comment 10

[Paul Craciunoiu [:paulc]]

Should we get this to prod now?

Comment 11

[James Socol [:jsocol, :james]]

r54585 (prod)