518941 - Update libvorbis to pick up fix for some files encoded with libvorbis beta1

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

SVN r16552 includes a fix to libvorbis that prevents the decoder from rejecting some valid files produced with the beta4 encoder.  These may not be particularly common files, but we should pick this simple fix up anyway.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: patch v0

Update libvorbis to SVN r16552.

This needs a test, but I don't have a file which is fixed by this patch handy.

Comment 2

[Matthew Gregan [:kinetik]]

It's actually the beta1 encoder.  Test file in URL.  Unfortunately it doesn't play on trunk *or* with the patch applied.  Haven't investigated why yet.

Comment 3

[Matthew Gregan [:kinetik]]

Attachment: patch v1

Same, but with a test.  This also fixes the comments above gPlayTests, which should've been above gErrorTests (I messed them up in bug 481057).

Included test file does not play on current trunk, but does play with patch applied (comment 2 is out of date--suspect that was fixed by oggplay updates).  Note that the test does not fail every time when the patch is not applied, but I can't work out why.

Comment 4

[Matthew Gregan [:kinetik]]

We took the broken libvorbis update on 1.9.1 for 1.9.1.4, so we should take this fix to ensure we don't regress anything.

Also see bug 507167 comment 16.

Comment 5

[Matthew Gregan [:kinetik]]

Posted the libvorbis update to bug 507167.  Includes the test from this bug.  Marking this as depending on that.

Comment 6

[Matthew Gregan [:kinetik]]

http://hg.mozilla.org/mozilla-central/rev/196956e36ed2

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Fixed on 1.9.2 by checkin of bug 507167.

Comment 8

[Matthew Gregan [:kinetik]]

Checked in to 1.9.1 too.

Comment 9

[Al Billings [:abillings - ex-MoCo]]

Do we have sample rejected files somewhere that can be used to verify this fix for Firefox 3.5.4?

Comment 10

[Matthew Gregan [:kinetik]]

There's one in the bug URL.  I don't have any others to test with.

Comment 11

[Al Billings [:abillings - ex-MoCo]]

Er, I missed the url. Sorry about that.

I verified that it doesn't play in 1.9.1.3 on OS X but does play on 1.9.1.4 (Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.4) Gecko/20091016 Firefox/3.5.4) so this looks good.