519147 - "Sign In" is greyed out in Weave menu when Firefox starts, in Weave 0.7pre4

Status: VERIFIED FIXED

(Firefox :: Sync, defect, P2)

Description

[Daniel Holbert [:dholbert]]

STEPS TO REPRODUCE:
 1. Install Weave 0.7pre4 in a fresh Firefox profile, & restart Firefox
 2. Enter your existing Weave login credentials on the Weave firstrun page, and click through the rest of the firstrun process, accepting all the defaults.
 3. Restart Firefox (once you're done with the firstrun stuff)
 4. Click the Weave context menu.  Or, open the Tools menu, and look at the Weave submenu.

ACTUAL RESULTS: "Sign In" is greyed out.
EXPECTED RESULTS: "Sign In" should be available.

NOTE: I can still sign in by manually visiting the "about:weave" URL.

NOTE: I initially hit this bug just now when upgrading from Weave 0.7pre3 to 0.7pre4.  As suggested by the STR above, I've confirmed that it also happens in a fresh profile + weave 0.7pre4 with weave credentials entered.

Comment 1

[Ed Lee :Mardak]

Can you check if the Sign In item stays grayed out after a minute or so? Weave might not be initialized yet, but we should probably show something in the UI relating to that then..

Comment 2

[Daniel Holbert [:dholbert]]

I've had firefox running for almost an hour, and the Sig nIn item is still grayed out.

Comment 3

[Daniel Holbert [:dholbert]]

I just upgraded to Weave 0.7, and this is still broken in that version.

Browser: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20090930 Minefield/3.7a1pre

Comment 4

[Ed Lee :Mardak]

Hrm, there's 3 ways to make the sign in menu item disabled.. could you try this in the Error Console?

Components.utils.import("resource://weave/service.js"); [Weave.Svc.IO.offline, Weave.Service.status.service == Weave.STATUS_DELAYED, Weave.Service.locked]

That should result in false,false,false when Sign In is made clickable.

Comment 5

[Daniel Holbert [:dholbert]]

(In reply to comment #4)
> Components.utils.import("resource://weave/service.js"); [Weave.Svc.IO.offline,
> Weave.Service.status.service == Weave.STATUS_DELAYED, Weave.Service.locked]

When I start Firefox (and "sign in" is grayed out), that command returns:
 false,true,

If I manually visit about:weave and sign in, then the command returns:
 false,false,false

Comment 6

[Ed Lee :Mardak]

And how about if you restart firefox without about:weave in session restore and wait a minute?

Comment 7

[Daniel Holbert [:dholbert]]

...then nothing happens.  BUT I figured it out -- it's because I have "Keep me signed into weave" *unchecked* in about:weave.

If I _check_ that box (and then log in & out of weave[1]) and then restart Firefox, **THEN** Weave will attempt to automatically log in in the background after a few seconds.

Since I have a master password, this background login triggers an unexpected Master Password dialog.  If I enter my password, then weave logs me in, and everything's fine.  But if I dismiss the dialog, I'm stuck with this bug.

[1] AFAICT, changes to the "keep me signed into Weave" checkbox don't take effect unless I sign into weave after toggling the box.

Comment 8

[Daniel Holbert [:dholbert]]

I've tested this in a fresh profile, both with & without a master password.

As far as I can tell, the "first minute" Weave initialization consists of:
 - If auto-login ("keep me signed into weave") is disabled, do nothing.  Sign In stays grayed out -- BAD!
 - If auto-login is enabled, then:
   -- If profile has no master password, log in -- GOOD.
   -- If profile has a master password, prompt for the master password.
     --- If user dismisses dialog, give up. Sign in stays grayed out -- BAD!
     --- If user enters correct master password, sign in. -- GOOD.
     --- (if user enters incorrect master password, keep prompting until they get it right or dismiss the dialog)

Comment 9

[Ed Lee :Mardak]

mconnor: we probably just need to reset the service status to not be delayed before doing autoconnect. Otherwise, service status stays DELAYED until login.. which is disabled from the menu.

Comment 10

[Daniel Holbert [:dholbert]]

(In reply to comment #7)
> [1] AFAICT, changes to the "keep me signed into Weave" checkbox don't take
> effect unless I sign into weave after toggling the box.

(FWIW, I just filed bug 520039 on this separate issue)

Comment 11

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/9ba199fa5574
Switch back to STATUS_OK (from STATUS_DELAYED) when the delayed startup is actually called.

Comment 12

[Daniel Holbert [:dholbert]]

Verified fixed in Weave 0.8pre1