519256 - Only unique plugins should be processed; QuickTime has 7 instances

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Plugins, defect)

Description

[Austin King [:ozten]]

When creating the "browserPlugins" from the navigator.plugins object, we should filter out duplicate objects based on plugin.name.

Expected: One QuickTime plugin

Actual: We run through detection logic 7 times for QuickTime.

This does not affect the Mac OS X platform.

Comment 1

[Austin King [:ozten]]

Committing a fix to trunk, with several other changes to the code as well. r52481. 

Stage is taking up to 30 minutes to sync...

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Thx, Austin; verified fixed on https://www-trunk.stage.mozilla.com/en-US/plugincheck/.

Comment 4

[(not currently active) Ted Mielczarek]

Interestingly, my QuickTime install had one .dll that was reporting a lower version number (7.6.2), with all the other ones reporting the latest version (7.6.4). The plugincheck page gave me two entries for QuickTime, one showing 7.6.2 and one showing 7.6.4, but suggested that they were both out of date.

Comment 5

[Austin King [:ozten]]

(In reply to comment #4)
Ted can you go to http://pfs2.ozten.com/pfs2_json.html and then attach the output (select all, paste) and I will look into it. Also add what os and Fx version. Thanks.

Comment 6

[Austin King [:ozten]]

(In reply to comment #4)
Ted provided
http://pastebin.mozilla.org/676606 and about:plugins output -
http://pastebin.mozilla.org/676608

The way we filter out duplicates from the navigator.plugins object is based soley on plugin name. We end up with 2 QuickTime because Apple puts the version number in the name.

The root cause of this is Apple's plugin install has a bug (AFAIK) and I don't think we should put in a special fix for this weird case, unless it's more widely reported.

*We should* push Apple to fix their iTunes / QuickTime update process to remove older plugins.

Comment 7

[(not currently active) Ted Mielczarek]

Yeah. It would be nice if it handled the "up to date" status of each of those versions correctly, though. In Firefox 3.5, it tells me they're both up-to-date, whereas on trunk it tells me they're both out-of-date.