Closed
Bug 519573
Opened 15 years ago
Closed 15 years ago
Notifications of anonymous-user followups in forum posts have "" as sender/attribution
Categories
(support.mozilla.org :: Forum, task)
support.mozilla.org
Forum
Tracking
(Not tracked)
VERIFIED
FIXED
1.4.2
People
(Reporter: stephend, Assigned: paulc)
References
()
Details
(Whiteboard: sumo_only)
Attachments
(1 file, 2 obsolete files)
1.33 KB,
patch
|
jsocol
:
review+
|
Details | Diff | Splinter Review |
STR: 1. While logged in, load http://support-stage.mozilla.org/en-US/forum/1 2. Click on "Ask a New Question" 3. Go through all four pages and check "Email me when my question has updates" 4. Click on "View Your Support Question" (or whatever it's called) 5. Log out 6. As an anonymous user, follow-up with a post Actual: "" has posted a reply to a thread you're watching. You can view the thread and reply at the following URL: https://support-stage.mozilla.org/en-US/forum/1/en-US/1/446895#threadId446896 Expected: Something that indicates the user was anonymous
Updated•15 years ago
|
Target Milestone: --- → 1.4.2
Assignee | ||
Comment 1•15 years ago
|
||
This should do it.
Assignee: nobody → paulc
Attachment #404701 -
Flags: review?(james)
Comment 2•15 years ago
|
||
Comment on attachment 404701 [details] [diff] [review] v1 To clarify the STR: make sure when you post anonymously to leave the name field blank. With this patch I still saw: "" has posted a reply to a thread you're watching. You can view the thread and reply at the following URL:
Attachment #404701 -
Flags: review?(james) → review-
Assignee | ||
Comment 3•15 years ago
|
||
Okay. Did not account for that case, I admit! What should the default be if nothing is supplied? "An anonymous user", "A Firefox user"?
Comment 4•15 years ago
|
||
In any other case it seems to work without the patch--Stephen can you confirm that?--so I think only the empty case is important. "An anonymous user" works for me.
Reporter | ||
Comment 5•15 years ago
|
||
(In reply to comment #4) > In any other case it seems to work without the patch--Stephen can you confirm > that?--so I think only the empty case is important. "An anonymous user" works > for me. Yeah, this is only when you leave the name field blank.
Assignee | ||
Comment 6•15 years ago
|
||
With this patch, if author is empty, it defaults to "An anonymous user" Note that, because this is in the template, we can make it product-specific.
Attachment #404701 -
Attachment is obsolete: true
Attachment #407581 -
Flags: review?(james)
Comment 7•15 years ago
|
||
Comment on attachment 407581 [details] [diff] [review] v2 It works for me with only the template change. Why the change to tiki-ask_a_question.php?
Assignee | ||
Comment 8•15 years ago
|
||
(In reply to comment #7) > It works for me with only the template change. Why the change to > tiki-ask_a_question.php? Oh, does it work for anonymous users when they specify the name? Looking at the code it seemed like it shouldn't be working - hence, the change.
Comment 9•15 years ago
|
||
Yep, see comments 4 and 5.
Assignee | ||
Comment 10•15 years ago
|
||
No more change to tiki-ask_a_question.php
Attachment #407581 -
Attachment is obsolete: true
Attachment #407811 -
Flags: review?(james)
Attachment #407581 -
Flags: review?(james)
Comment 11•15 years ago
|
||
Comment on attachment 407811 [details] [diff] [review] v3 This is exactly what I tested locally. (Sorry, I meant to r+ this on Friday but I guess I didn't hit submit.)
Attachment #407811 -
Flags: review?(james) → review+
Assignee | ||
Comment 12•15 years ago
|
||
r54485 (trunk)
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 13•15 years ago
|
||
Verified FIXED: Date: Wed, 28 Oct 2009 13:33:22 -0700 To: stephen.donner@gmail.com Subject: Reply notification: test MIME-Version: 1.0 From: notifications@support.mozilla.com Reply-To: <notifications@support.mozilla.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-ID: <ks8rrm.1iaj5j@support-stage.mozilla.org> An anonymous user has posted a reply to a thread you're watching. You can view the thread and reply at the following URL: https://support-stage.mozilla.org/en-US/forum/1/446895#threadId447027
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 14•15 years ago
|
||
Awesome. Wow that's fast!
Assignee | ||
Comment 15•15 years ago
|
||
r54623 (prod)
Updated•15 years ago
|
Whiteboard: sumo_only
You need to log in
before you can comment on or make changes to this bug.
Description
•