Closed Bug 519607 Opened 15 years ago Closed 15 years ago

Restore default set in toolbar customization doesn't do size and mode correctly

Categories

(Thunderbird :: Toolbars and Tabs, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0rc1

People

(Reporter: philor, Assigned: philor)

Details

Attachments

(1 file)

The API for customization "says" (not that we document anything) that you need to put a defaultmode attribute on the toolbox, and if you want small icons as default, a defaulticonsize="small" attribute on the toolbox (and, if you want per-toolbar mode or size, also put defaultmode/defaulticonsize on individual toolbars to override the toolbox). With our three customizable toolboxes, we have a total of zero defaultmode attributes, and with our one (so far) where we default to small icons, we also have zero defaulticonsize attributes.
Attached patch Fix v.1Splinter Review
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #404448 - Flags: review?(mkmelin+mozilla)
Comment on attachment 404448 [details] [diff] [review]
Fix v.1

Looks good. r=mkmelin
Attachment #404448 - Flags: review?(mkmelin+mozilla) → review+
Flags: blocking-thunderbird3+
http://hg.mozilla.org/comm-central/rev/0a508d099a45
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0rc1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: