Closed
Bug 519822
Opened 15 years ago
Closed 15 years ago
polish tweaks for the header button box on mac
Categories
(Thunderbird :: Message Reader UI, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0rc1
People
(Reporter: andreasn, Assigned: andreasn)
Details
(Keywords: polish, Whiteboard: [no l10n impact])
Attachments
(3 files, 1 obsolete file)
15.93 KB,
image/png
|
Details | |
1.60 KB,
image/png
|
Details | |
6.53 KB,
patch
|
dmosedale
:
review+
dmosedale
:
ui-review+
|
Details | Diff | Splinter Review |
Two issues that was brought up on IRC: * Forward icon have a different tint of blue that reply. * The text color used in the button makes them look disabled.
Comment 1•15 years ago
|
||
The reply button is vertically a few pixels short.
Flags: blocking-thunderbird3?
Keywords: polish
Updated•15 years ago
|
Hardware: x86 → All
Target Milestone: --- → Thunderbird 3.0rc1
Assignee | ||
Comment 2•15 years ago
|
||
Comment 3•15 years ago
|
||
I think if we are going to work on some new icons for the mac we should try some simplified versions of the current ones. These buttons have a bit less vertical height than the toolbar buttons so I think we want to optimize for that by only showing the most necessary pieces. I'm thinking of the Mail.app type icons (as they are similar sized buttons) where we are showing mostly a sweeping arrow without anything else around it. Also it's likely that the toolbar buttons have some text-shadow happening to make them look more mac toolbar button like and that is creating this color difference as well.
Assignee | ||
Comment 4•15 years ago
|
||
Assignee | ||
Comment 5•15 years ago
|
||
Bryan: what about something like this?
Updated•15 years ago
|
Whiteboard: [no l10n impact]
Comment 6•15 years ago
|
||
I like those a lot, very simple and effective. Lets try them out on the mac to see how they look in the buttons.
Updated•15 years ago
|
Flags: blocking-thunderbird3? → blocking-thunderbird3+
Updated•15 years ago
|
Priority: -- → P2
Assignee | ||
Comment 7•15 years ago
|
||
Attachment #404026 -
Attachment is obsolete: true
Attachment #405052 -
Flags: ui-review?(clarkbw)
Assignee | ||
Updated•15 years ago
|
Attachment #405052 -
Flags: review?(dmose)
Comment 8•15 years ago
|
||
Comment on attachment 405052 [details] [diff] [review] patch with new icons and text color fixed r=dmose
Attachment #405052 -
Flags: review?(dmose) → review+
Comment 9•15 years ago
|
||
Comment on attachment 405052 [details] [diff] [review] patch with new icons and text color fixed Comment 6 reads to me like it is ui-review+, so I'm going to mark it as such and land.
Attachment #405052 -
Flags: ui-review?(clarkbw) → ui-review+
Comment 10•15 years ago
|
||
http://build.mozillamessaging.com/mercurial/comm-central/rev/f04e261ccca3
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•