520894 - OS/2 browser doesn't show anything in the main window

Status: RESOLVED FIXED

(Core Graveyard :: Widget: OS/2, defect)

Description

[Walter Meinl]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.3a1pre) Gecko/20091006 Minefield/3.7a1pre
Build Identifier: 

After checkin of bug515446 the browser builds fine, address bar and bookmarks are present, the tabs show the title of a webpage opened but not the page (and scrollbars, which may be absent because there's nothing to scroll). The main window is just a background.
Not surely (but most likely) related opening the history or bookmarks window will crash the browser.
Since the bits of bug515446 were also checked into 1.9.2 we will have to find a fix soon.

Reproducible: Always

Comment 1

[Rich Walsh]

Got it fixed, patch in a few minutes...

Comment 2

[Rich Walsh]

Attachment: fix widget creation failure

The problem was these lines in nsWindow::Create where hwndP was accidentally redefined.
  HWND hwndP = (HWND)aNativeParent;
  if (!hwndP) {
    HWND hwndP = aParent ? [etc]
  }

Since this code was a mashup of two previously separate methods, it was ..uhh.. confusing so I rewrote it for greater clarity.

Comment 3

[Markus Stange [:mstange]]

Uouhps. Sorry for not paying enough attention.

Comment 4

[Peter Weilbacher]

http://hg.mozilla.org/mozilla-central/rev/4634de0ae97c

Comment 5

[Rich Walsh]

This needs to be pushed to the 1.9.2 branch as well.  I just looked at that version of nsWindow.cpp & found the same error there.

Comment 6

[Peter Weilbacher]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/b90714b554ed

Comment 7

[Peter Weilbacher]

This was apparently too late for beta1, at least the tag FIREFOX_3_6b1_RELEASE does not contain the change.