Closed Bug 520937 Opened 15 years ago Closed 15 years ago

Win7 related errors on browser startup.

Categories

(Firefox :: General, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 3.7a1
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: Natch, Assigned: jimm)

References

Details

(Keywords: verified1.9.2)

Attachments

(1 file, 1 obsolete file)

Error: Cc[WINTASKBAR_CONTRACTID] is undefined
Line: 2533
Source File: chrome://browser/content/browser.js
________________________________________

Warning: reference to undefined property Cc[WINTASKBAR_CONTRACTID]
Line: 2533
Source File: chrome://browser/content/browser.js

I get these errors/warnings when I startup on trunk.
That was added by Rob Arnold in bug 474056.
Blocks: 474056
Do taskbar previews work for you?   See bug 520801.
Attached patch components check v.1 (obsolete) — Splinter Review
Attachment #405164 - Flags: review?(gavin.sharp)
Comment on attachment 405164 [details] [diff] [review]
components check v.1

>diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js

>+  if (!(WINTASKBAR_CONTRACTID in Cc))
>+    return { onOpenWindow: function () {}, onCloseWindow: function () {} };
>+
>   let taskbar = Cc[WINTASKBAR_CONTRACTID].getService(Ci.nsIWinTaskbar);
>   if (taskbar.available) {

I'd prefer:

if (WINTASKBAR_CONTRACTID in Cc &&
    Cc[WINTASKBAR_CONTRACTID].getService(Ci.nsIWinTaskbar).available) {
Attachment #405164 - Flags: review?(gavin.sharp) → review+
Attached patch components checkSplinter Review
Assignee: nobody → jmathies
Attachment #405164 - Attachment is obsolete: true
Attachment #405166 - Flags: approval1.9.2?
http://hg.mozilla.org/mozilla-central/rev/63c6082e6230
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment on attachment 405166 [details] [diff] [review]
components check

a192=beltzner
Attachment #405166 - Flags: approval1.9.2? → approval1.9.2+
Flags: in-testsuite-
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20091008 Minefield/3.7a1pre
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2b1pre) Gecko/20091008 Namoroka/3.6b1pre

V. Fixed. I get no errors now.
Status: RESOLVED → VERIFIED
Keywords: verified1.9.2
Target Milestone: --- → Firefox 3.7a1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: