Closed Bug 521364 Opened 15 years ago Closed 15 years ago

Make jitstats output not miss stats

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- beta4-fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

I discovered today that the timeoutIntoInterpreter stat isn't listed for some reason.  Let's not have that happen again.
Attached patch Like soSplinter Review
Attachment #405389 - Flags: review?
Attachment #405389 - Flags: review? → review?(dvander)
Attachment #405389 - Flags: review?(dvander) → review+
Comment on attachment 405389 [details] [diff] [review]
Like so

Stolen, at bz's request.

Cool patch, helps me be lazy.

>+        debug_only_printf(LC_TMStats, "%s", "recorder");
>+        debug_only_printf(LC_TMStats, "%s", "\n");
>+        debug_only_printf(LC_TMStats, "%s", "monitor");
>+        debug_only_printf(LC_TMStats, "%s", "\n");

I suspect you used the eta-expanded form because debug_only_printf(LC_TMStats, "recorder") was an error.  For that we have debug_only_print0.  Yay macros!
> debug_only_printf(LC_TMStats, "recorder") was an error.

Yep.  ;)

> For that we have debug_only_print0.

Aha!  Perfect.  Will change to that.
Pushed http://hg.mozilla.org/tracemonkey/rev/9ca9a164711c with the debug_only_print0
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/9ca9a164711c
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: