521610 - Unwanted shortcuts in Mark dropdown of Mail Toolbar

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[:Hb]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5pre) Gecko/20091009 Lightning/1.0pre SeaMonkey/2.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5pre) Gecko/20091009 Lightning/1.0pre SeaMonkey/2.0pre (Linux is affected too)

Current user interface guidelines say that toolbar buttons should not have hints for keyboard shortcuts.

Reproducible: Always

Steps to Reproduce:
The Mark button in Mail Toolbar incorrectly shows shortcuts. All other buttons in the toolbar don't show them.
Actual Results:  
This is only a glitch in the UI. Mail display itself is not affected (Bug 521591).

Comment 1

[rsx11m]

Taking, I'll have a patch later today.

Comment 2

[rsx11m]

Attachment: Easy fix [Checkin: Comments 5 & 6]

Patch to remove the "key" attributes from the menu list for button-markPopup.
The keyboard shortcuts themselves remain functional, only their display in the button's context menu is omitted.

This patch should be simple enough to qualify for a combined r/sr? request.

Comment 3

[rsx11m]

Comment on attachment 409446 [details] [diff] [review]
Easy fix
[Checkin: Comments 5 & 6]

Thanks Neil. Requesting approval for 2.0.1, it's a trivial change affecting appearance only, no string or feature changes. No obvious risk involved.

Comment 4

[rsx11m]

Push for comm-central and comm-1.9.1, please (does not affect Thunderbird);
I'm canceling the pending wanted-sm2.0? request as this got 2.0.1 approval.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 409446 [details] [diff] [review]
Easy fix
[Checkin: Comments 5 & 6]


http://hg.mozilla.org/comm-central/rev/791c8ec2f336

Comment 6

[Ian Neal]

Comment on attachment 409446 [details] [diff] [review]
Easy fix
[Checkin: Comments 5 & 6]

http://hg.mozilla.org/releases/comm-1.9.1/rev/0e1adb3b9ac8