Closed Bug 522417 Opened 15 years ago Closed 15 years ago

Closing a blocked site with Return now beeps

Categories

(Camino Graveyard :: General, defect)

Product:
Camino Graveyard
Component:
General
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Camino2.0

People

(Reporter: alqahira, Assigned: stuart.morgan+bugzilla)

References

(
URL
)

Details

(Keywords: regression, Whiteboard: [camino-2.0])

Attachments

(1 file)

fix
1.19 KB, patch
mikepinkerton
: superreview+
Details | Diff | Splinter Review 
Apparently I spoke too soon this morning :( (or at least I think so)

Now (sometime since b4 and by 10-10), trying to close a blocked site using return generates a beep in addition to closing the page.  It shouldn't beep (and it didn't in b4).
It's my fault, but fix coming.

From IRC debugging, there's an extra requirement: there has to be another tab, so the whole window doesn't close.
Assignee: nobody → stuart.morgan+bugzilla
Status: NEW → ASSIGNED
Flags: camino2.0+
Keywords: regressionwindow-wanted
Target Milestone: --- → Camino2.0
Attached patch fix — — Splinter Review 

        Attachment #406394 -
        Flags: superreview?(mikepinkerton)

    
    

    
  
Comment on attachment 406394 [details] [diff] [review]
fix

sr=pink

        Attachment #406394 -
        Flags: superreview?(mikepinkerton) → superreview+

    
    

    
  
Landed on CVS and CAMINO_2_0_BRANCH.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [camino-2.0]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: