522507 - Find is shown on top of the page

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091015
Fennec/1.0b5pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20091015
Fennec/1.0b5pre

Steps to Reproduce:
1. Press Ctrl+F

Actual Results:
Find bar now shows up at the top of the screen.

Expected Results:
The find bar should show up at the bottom until https://bugzilla.mozilla.org/show_bug.cgi?id=519833 is resolved:fixed. Once it is, then the find bar will be innaccessible

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Even though we are turning findbar off for Fennec 1.0 the code will still be there and could be turned on by an add-on. So I want to make sure this isn't too broken.

This patch adds the left/top back and handles the resize.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/a986171e31e9

Comment 3

[Aakash Desai [:aakashd]]

Now that the find bar is disabled thanks to  https://bugzilla.mozilla.org/show_bug.cgi?id=519833 , its going to be hard to verify this other than by code inspection...which isn't nominal. I'm going to stick this in the verify-when-there's-an-addon-that-uses-it file manager.