Closed Bug 522713 Opened 15 years ago Closed 15 years ago

Port |Bug 448602 - Have a way to enumerate event listeners| to comm-central (apps)

Categories

(MailNews Core :: Build Config, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.1a1

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

(Keywords: fixed-seamonkey2.0.1)

Attachments

(3 files)

      No description provided.
Flags: in-testsuite-
"approval-seamonkey2.0=?":
no risk, for 'default' hg branch only.
Attachment #406698 - Flags: review?(kairo)
Attachment #406698 - Flags: approval-seamonkey2.0?
Looking for "approval-thunderbird3=?" too:
no risk, m-c only.
Attachment #406701 - Flags: review?(bugzilla)
Blocks: 521428
Comment on attachment 406698 [details] [diff] [review]
(Av1-SM) Just package it
[Checkin: See comment 6+14]

A definite no for the 2.0 relbranch, setting request to 2.0.1 instead, which is current 1.9.1-based dev version.
Attachment #406698 - Flags: approval-seamonkey2.0?
Attachment #406698 - Flags: approval-seamonkey2.0.1?
Attachment #406698 - Flags: approval-seamonkey2.0-
(In reply to comment #4)
> (From update of attachment 406698 [details] [diff] [review])
> setting request to 2.0.1 instead, which is current 1.9.1-based dev version.

Agreed, that's what I meant: I just didn't know if *2.0.1 applied yet.
Attachment #406698 - Flags: review?(kairo)
Attachment #406698 - Flags: review+
Attachment #406698 - Flags: approval-seamonkey2.0.1?
Attachment #406698 - Flags: approval-seamonkey2.0.1+
Comment on attachment 406698 [details] [diff] [review]
(Av1-SM) Just package it
[Checkin: See comment 6+14]


http://hg.mozilla.org/comm-central/rev/74e007ed380f
Attachment #406698 - Attachment description: (Av1-SM) Just package it → (Av1-SM) Just package it [Checkin: Comment 6]
Comment on attachment 406702 [details] [diff] [review]
(Cv1-SB) Just package it, Improve sort order
[Checkin: See comment 8+14 & 11]

How can we make use of this? Is there some sort of dev doc for this?

For calendar, please push on both comm-central and comm-1.9.1
Attachment #406702 - Flags: review?(philipp) → review+
Comment on attachment 406702 [details] [diff] [review]
(Cv1-SB) Just package it, Improve sort order
[Checkin: See comment 8+14 & 11]


http://hg.mozilla.org/comm-central/rev/13f9b3618d2f
without the "#ifndef MOZILLA_1_9_1_BRANCH".
Attachment #406702 - Attachment description: (Cv1-SB) Just package it, Improve sort order → (Cv1-SB) Just package it, Improve sort order [Checkin: See comment 8]
(In reply to comment #7)
> How can we make use of this? Is there some sort of dev doc for this?

Bug 448602 (still) has 'dev-doc-needed' flag...
(In reply to comment #8)
> (From update of attachment 406702 [details] [diff] [review])
> 
> http://hg.mozilla.org/comm-central/rev/13f9b3618d2f
> without the "#ifndef MOZILLA_1_9_1_BRANCH".

According to comment#7 this patch should have been pushed to comm-1.9.1, too!
Comment on attachment 406702 [details] [diff] [review]
(Cv1-SB) Just package it, Improve sort order
[Checkin: See comment 8+14 & 11]


http://hg.mozilla.org/releases/comm-1.9.1/rev/f12bda2a09d3
(Cv1-SB-191) Improve sort order. [Only]

(In reply to comment #10)
> According to comment#7 this patch should have been pushed to comm-1.9.1, too!

s/should have/still needs/, please!
I was waiting to land another patch of mine at the same time, but that may eventually not happen for a while...
Attachment #406702 - Attachment description: (Cv1-SB) Just package it, Improve sort order [Checkin: See comment 8] → (Cv1-SB) Just package it, Improve sort order [Checkin: See comment 8 & 11]
Comment on attachment 406701 [details] [diff] [review]
(Bv1-TB) Just package it, Improve sort order
[Checkin: See comment 13]

> #ifndef MOZILLA_1_9_1_BRANCH
>+#ifndef MOZILLA_1_9_2_BRANCH
> bin\components\content_canvas.xpt
>+bin\components\content_events.xpt
>+#endif
> #endif

Just drop the MOZILLA_1_9_1_BRANCH ifndef now please. r=Standard8 with that fixed.
Attachment #406701 - Flags: review?(bugzilla) → review+
Blocks: 523820
Comment on attachment 406701 [details] [diff] [review]
(Bv1-TB) Just package it, Improve sort order
[Checkin: See comment 13]


http://hg.mozilla.org/comm-central/rev/6134122abbcd
Bv1-TB, with comment 12 suggestion(s),
and enable it on m-1.9.2 too now.
Attachment #406701 - Attachment description: (Bv1-TB) Just package it, Improve sort order → (Bv1-TB) Just package it, Improve sort order [Checkin: See comment 13]
http://hg.mozilla.org/comm-central/rev/2f4046f9f31b
(Dv1-SB-SM) Needed on m-1.9.2 too now.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1a1
Attachment #406698 - Attachment description: (Av1-SM) Just package it [Checkin: Comment 6] → (Av1-SM) Just package it [Checkin: See comment 6+14]
Attachment #406702 - Attachment description: (Cv1-SB) Just package it, Improve sort order [Checkin: See comment 8 & 11] → (Cv1-SB) Just package it, Improve sort order [Checkin: See comment 8+14 & 11]
Depends on: 538832
Target Milestone: Thunderbird 3.1a1 → Thunderbird 3.2a1
No longer depends on: 538832
Target Milestone: Thunderbird 3.2a1 → Thunderbird 3.1a1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: