522943 - CRC check fail with nssdbm3.chk on Windows partial updates

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Robert Kaiser]

Filing this in releng as the fixes need to be done in the patcher configs.

When checking the win32_update_verify output for SeaMonkey 2.0 RC2, I noticed CRC errors with nssdbm3.chk on the partials (RC1->RC2), while complete updates worked fine. I tried a betatest update on an actual Windows machine and saw the same problem.

Some investigation led me to see that this is bug 470811 (caused once more by bug 404340) creeping up again after bug 509558, i.e. we're packaging one more .chk file but not forcing the update on it.

We need to extend the approach in patcher configs added in attachment 357731 [details] [diff] [review] to this new .chk file everywhere we package it.

Comment 1

[Robert Kaiser]

As a note, this file is new in Gecko 1.9.1.4 (talking of the 1.9.1 branch only, others are affected accordingly), which means Firefox only needs the fix in time for 1.9.1.5, when this file will pre-exist on update for the first time.

Comment 2

[Robert Kaiser]

I fixed this for SeaMonkey now, will re-generate updates with that config and see if thigs work better then.

Checking in moz191-seamonkey-branch-patcher2.cfg;
/cvsroot/mozilla/tools/patcher-configs/moz191-seamonkey-branch-patcher2.cfg,v  <--  moz191-seamonkey-branch-patcher2.cfg
new revision: 1.9; previous revision: 1.8
done

Comment 3

[Robert Kaiser]

OK, the patch worked for SeaMonkey, Firefox will need to have it in time when the first updates applying on a pre-existing nssdbm3.chk will come around. This will at least be for 3.5.5, but I'm not sure what other branches/releases are affected, so I'm a bit out of clue as to which configs to patch.
I'll leave this to releng because of that.

gozer, you'll also need to do this for Thunderbird.

Comment 4

[Robert Kaiser]

Natch, I intentionally didn't request any flags, as I saw no need to cause work for drivers here when releng can just conveniently fix it with a lot of time to go until it hits any Firefox releases.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Add force instruction for 1.9.1 and 1.9.2 branches

Thanks for filing this KaiRo, it was oe my to do list for this week.

We use NSS 3.12.4 on the 1.9.1
  http://mxr.mozilla.org/mozilla1.9.1/source/security/nss/lib/nss/nss.h#63
and 1.9.2
  http://mxr.mozilla.org/mozilla1.9.2/source/security/nss/lib/nss/nss.h#63
branches, but not 1.9.0
  http://mxr.mozilla.org/seamonkey/source/security/nss/lib/nss/nss.h#63
or 1.8.1
  http://mxr.mozilla.org/mozilla1.8/source/security/nss/lib/nss/nss.h#63
No need to change major update configs as they're complete updates only.

Comment 6

[Philippe M. Chiasson (:gozer)]

Attachment: [checked in] Add force instruction for Thunderbird 1.9.1

And here is a similar patch for Thunderbird on 1.9.1

Comment 7

[Philippe M. Chiasson (:gozer)]

Comment on attachment 407041 [details] [diff] [review]
[checked in] Add force instruction for Thunderbird 1.9.1

Checking in moz19-thunderbird-branch-patcher2.cfg;
/cvsroot/mozilla/tools/patcher-configs/moz19-thunderbird-branch-patcher2.cfg,v  <--  moz19-thunderbird-branch-patcher2.cfg
new revision: 1.6; previous revision: 1.5
done

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 406940 [details] [diff] [review]
Add force instruction for 1.9.1 and 1.9.2 branches

Checking in moz191-branch-patcher2.cfg;
/cvsroot/mozilla/tools/patcher-configs/moz191-branch-patcher2.cfg,v  <--  moz191-branch-patcher2.cfg
new revision: 1.36; previous revision: 1.35
done
Checking in moz192-branch-patcher2.cfg;
/cvsroot/mozilla/tools/patcher-configs/moz192-branch-patcher2.cfg,v  <--  moz192-branch-patcher2.cfg
new revision: 1.6; previous revision: 1.5
done