52296 - More Info button in Smart Browsing Pref panel needs to go to this URL

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P2)

Description

[Claudius Gayle]

***Overview Description: 

  The 'More Info' button in the Smart Browsing preferences panel needs to launch
the following URL (noted in URL field above):
http://info.netscape.com/fwd/rlstatic/http://home.netscape.com/escapes/keywords/index.html

This has already been implemented on the mozilla side in bug 50873. All that
is required is a simple textstring change. From Blake, " note that the only change that has to 
be made is to smartBrowsingURL."

Comment 1

[Claudius Gayle]

adding nsbeta3 keyword for triage. *note this needs to be reassigned to appropriate
eng as well.

Comment 2

[Blake Ross]

change is in brand.properties

Comment 3

[johng]

nav triage team:
+, P2, reassign to radha, cc'ing blake

Comment 4

[sairuh (rarely reading bugmail)]

nsonly (i feel such bugs should be filed here in bugzilla, since the codebase
ain't hidden, afaik.)

Comment 5

[Blake Ross]

cc jglick since she's doing text changes.  Jennifer, all you have to do is 
change the URL after smartBrowsingURL= in brand.properties 
mozilla/xpfe/global/resources/locale/en-US to the netscape.com one that 
Claudius mentioned.

Comment 6

[Blake Ross]

I was a little mistaken.  smartBrowsingURL= won't be in the file at all.  just 
add this to the bottom of that file:

smartBrowsingURL=http://info.netscape.com/fwd/rlstatic/http://home.netscape.com/
escapes/keywords/index.html

Comment 7

[jglick]

Sorry I wasn't able to fix this one. This is in the Netscape tree only, and I 
haven't learned how to do that yet. :-(

Comment 8

[selmer (gone)]

pdt agrees p2.

Comment 9

[Radha on family leave (not reading bugmail)]

Is this button "More information"  supposed to go to www.mozilla.org for mozilla 
builds and to the url above for commercial builds? Clicking on this button in 
mozilla builds takes me properly to mozilla.org. But in commercial builds, 
clicking  on this button gives me the following JS exception,

JavaScript error:
 line 0: uncaught exception: [Exception... "Component returned failure code: 0x8
0004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult: "0x80
004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://communicator/content
/pref/pref-smart_browsing.xul :: moreInfo :: line 145"  data: no]

There is a smartBrowsingURl entry in 
mozilla/xpfe/global/resources/locale/en-US/brand.propertis. But there is none in  
the ns tree counter part. Where should this entry go? in the mozilla tree or 
commercial tree? (Looks like commercial from blake's comments above). Is this 
button working at all for anybody in the commercial build. 

Comment 10

[Blake Ross]

Radha: yeah, to fix the exception all you should have to do is add this to the 
bottom of brand.properties in the comm tree:

smartBrowsingURL=http://info.netscape.com/fwd/rlstatic/http://home.netscape.com/
escapes/keywords/index.html

Comment 11

[Radha on family leave (not reading bugmail)]

Fix checked in

Comment 12

[sairuh (rarely reading bugmail)]

vrfy fixed using 2000.09.29.xx-n6 [opt comm branch bits] on linux, mac and
winnt. (bug 52372 still occurs, however.)

adding vtrunk kw to check the commercial trunk bits (um, sometime?) not flipping
the Verified bit here since the checkin occurred during the grey-period around
branching --however, if this fix *definitely* got in *before* the branch, feel
free to mark this verified.

Comment 13

[sairuh (rarely reading bugmail)]

vrfy fixed using opt comm *trunk* bits 2000.11.13.08 on mac, winnt and linux.