523477 - [Regression] Adding/Removing tabs increases width of tab sidebar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091020
Fennec/1.0b5pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20091020
Fennec/1.0b5pre

Steps to Reproduce:
1. Slide to open the tab sidebar
2. Create a new tab
3. Remove that tab

Actual Results:
On the n810 and n900 on both trunk and 1.9.2 nightly builds, the sidebar incerase in width when adding/removing a tab 

Expected Results: 
The tab sidebar shouldn't increase in width

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

hmm, each time I add a tab the sidebar gets a little bigger.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: patch

Use the same size for tabs than moz-column-size

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 407529 [details] [diff] [review]
patch

fixes the problem

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

but we need it for winmo too, right?

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #6)
> but we need it for winmo too, right?

Nope. The display:block which is the root cause of the problem has landed only on maemo for now.

However it is important to not forget it during the resolution of bug 523218.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/04164598a4a5

Comment 9

[Aakash Desai [:aakashd]]

Sweet, verified FIXED on builds:


Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091022
Fennec/1.0b5pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20091022
Fennec/1.0b5pre

Comment 10

[Aakash Desai [:aakashd]]

Tabbed Browsing regression testcase needed in litmus

Comment 11

[Aakash Desai [:aakashd]]

litmus testcases 7118 and 7379 have been updated for regression testing this bug.