Closed
Bug 523708
Opened 15 years ago
Closed 15 years ago
Move to 32px size for bookmarks, awesomebar, urlbar and search provider buttons
Categories
(Firefox for Android Graveyard :: Bookmarks, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
fennec1.0b5
People
(Reporter: mfinkle, Assigned: vingtetun)
References
Details
(Whiteboard: [polish])
Attachments
(1 file, 2 obsolete files)
7.25 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
In an effort to: * Use a more common image size * Larger is more visible * Scale better since it's usually 16 -> 32 we are going to try using 32px sizes (set in CSS) for the hildon and wince/high themes
Updated•15 years ago
|
Whiteboard: [polish]
Assignee | ||
Comment 2•15 years ago
|
||
Assignee: nobody → 21
Attachment #408763 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 3•15 years ago
|
||
Oups! It missed the search providers size in browser-high for wince
Attachment #408763 -
Attachment is obsolete: true
Attachment #408765 -
Flags: review?(mark.finkle)
Attachment #408763 -
Flags: review?(mark.finkle)
Reporter | ||
Comment 4•15 years ago
|
||
Comment on attachment 408765 [details] [diff] [review] Patch >diff -r 16a176ddd28c themes/wince/browser-high.css >+.autocomplete-item-label > image, >+.bookmark-item-label > image { >+ width: 32px; >+ height: 32px; >+ margin: 0mm 2.5mm 0mm 2mm; It would be nicer if we could 'margin' in wince/browser.css >+} >+ >+.autocomplete-item-url, >+.bookmark-item-url { >+ margin: 0; >+ margin-right: 2mm; >+ margin-left: 13.5mm; >+} It would be nicer if we could keep 'margin' and 'margin-right' in wince/browser.css margin-left might be better if it was a mix of padding-left/margin-left using 'px' and 'mm', like we do for hildon. >diff -r 16a176ddd28c themes/wince/browser-low.css >+.autocomplete-item-label > image, >+.bookmark-item-label > image { >+ width: 24px; >+ height: 24px; >+ margin: 0mm 2.5mm 0mm 2mm; >+} >+ >+.autocomplete-item-url, >+.bookmark-item-url { >+ margin: 0; >+ margin-right: 2mm; >+ margin-left: 11.5mm; >+} Same here >diff -r 16a176ddd28c themes/wince/browser.css >@@ -265,17 +265,17 @@ placeitem > .bookmark-manage > image { > width: 24px; > height: 24px; > max-width: 24px; > max-height: 24px; > margin: 1.5mm 2.5mm 0mm 2mm; > } What is this part? I see 24px Very close. We can get this into Beta 5
Attachment #408765 -
Flags: review?(mark.finkle) → review-
Assignee | ||
Comment 5•15 years ago
|
||
Address comments
Attachment #408765 -
Attachment is obsolete: true
Attachment #408847 -
Flags: review?(mark.finkle)
Reporter | ||
Updated•15 years ago
|
Attachment #408847 -
Flags: review?(mark.finkle) → review+
Reporter | ||
Comment 6•15 years ago
|
||
pushed: https://hg.mozilla.org/mobile-browser/rev/f22edbef9e4a
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → B5
Comment 7•15 years ago
|
||
verified FIXED on builds: Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b2pre) Gecko/20091029 Namoroka/3.6b2pre Fennec/1.0b5pre and Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091029 Namoroka/3.7a1pre Fennec/1.0b5pre
Status: RESOLVED → VERIFIED
Updated•14 years ago
|
Component: General → Bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•