523809 - crash while moving messages [@nsMsgDBView::GetThreadRootIndex(nsIMsgDBHdr*) ]

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Wayne Mery (:wsmwk)]

crash while moving messages [@nsMsgDBView::GetThreadRootIndex(nsIMsgDBHdr*) ]
#44 crash for 3.0b4

I don't have clear set of steps. I was in the midst of moving messages by drag and drop, ctrl+shift+M and also via context menu. A couple new subfolders was created minutes before, in local account.

my crash comment "One is gloda search stuck on "Searching"" documents that one tab (left running overnight) is a stuck gloda search. That search never returned results. No loop afaict. Might file separate bug on that.

bsmedberg also crashed http://crash-stats.mozilla.com/report/index/6fd356a1-ae5d-4cee-a132-23ffe2091014

bp-f0e6233f-657f-4956-96b9-66abe2091022
0	thunderbird.exe	nsMsgDBView::GetThreadRootIndex	 mailnews/base/src/nsMsgDBView.cpp:5337
1	thunderbird.exe	nsMsgSearchDBView::AddHdrFromFolder	mailnews/base/src/nsMsgSearchDBView.cpp:467
2	thunderbird.exe	nsMsgSearchDBView::InsertHdrFromFolder	mailnews/base/src/nsMsgSearchDBView.cpp:667
3	thunderbird.exe	nsMsgSearchDBView::OnSearchHit	mailnews/base/src/nsMsgSearchDBView.cpp:699
4	xpcom_core.dll	NS_InvokeByIndex_P	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101
5	thunderbird.exe	XPCWrappedNative::CallMethod	js/src/xpconnect/src/xpcwrappednative.cpp:2297
6	thunderbird.exe	XPC_WN_CallMethod	js/src/xpconnect/src/xpcwrappednativejsops.cpp:1590

Comment 1

[Wayne Mery (:wsmwk)]

forgot to say, this is not a new crash. appears in both 3.0b1 and b2.  My crash is the only one ever reported as a nightly.

Comment 2

[Kent James (:rkent)]

Attachment: Rev a: check for null header

Comment 3

[David :Bienvenu]

Comment on attachment 407780 [details] [diff] [review]
Rev a: check for null header

looks reasonable, thx. A warning or even an assertion in ::GetThreadRootIndex might be nice, since that should be highly unexpected.

Comment 4

[Kent James (:rkent)]

Attachment: Rev b: add NS_WARNING

Added the requested warning, now need approval for TB3 (for checkin once tree reopens).

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 407806 [details] [diff] [review]
Rev b: add NS_WARNING

Please check into trunk and branch.

Comment 6

[Kent James (:rkent)]

Comment on attachment 407806 [details] [diff] [review]
Rev b: add NS_WARNING

Checked into trunk http://hg.mozilla.org/comm-central/rev/b3c316ffedb3

Comment 7

[Kent James (:rkent)]

Comment on attachment 407806 [details] [diff] [review]
Rev b: add NS_WARNING

Checked into branch as http://hg.mozilla.org/releases/comm-1.9.1/rev/6cc118c9d633