Closed
Bug 523849
Opened 15 years ago
Closed 14 years ago
Add an api to expose flash.system.System.disposeXML()
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tamarin Graveyard
Virtual Machine
Tracking
(Not tracked)
RESOLVED
FIXED
Future
People
(Reporter: cpeyer, Assigned: treilly)
Details
Attachments
(1 file)
|
156.21 KB,
patch
|
edwsmith
:
review+
|
Details | Diff | Splinter Review |
System.disposeXML() was added to enable the end user to forcefully gc xml objects. There is no api to access it via the shell though. Code pushed to player branch with CL 592113.
Flags: in-testsuite?
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
|
||
Updated•15 years ago
|
Priority: -- → P3
Target Milestone: --- → flash10.1
Raising priority to 2 as the missing API impacts testing.
Assignee: nobody → treilly
Flags: flashplayer-qrb? → flashplayer-qrb+
Priority: P3 → P2
|
||
Updated•15 years ago
|
Flags: flashplayer-needsversioning+
|
|
||
Updated•15 years ago
|
Target Milestone: flash10.1 → Future
|
|
||
Updated•15 years ago
|
Priority: P2 → --
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #473059 -
Flags: review?(edwsmith)
|
||
Comment 3•14 years ago
|
||
Instead of duplicating the code API should we just have one implementation and keep it in Tamarin? (Same for ByteArray).
|
|
||
Comment 4•14 years ago
|
||
Comment on attachment 473059 [details] [diff] [review] Add same API player has R+ since nothing is obviously wrong, but i think we could do better than cut+paste for this, ByteArray, and anything else that fits this pattern.
Attachment #473059 -
Flags: review?(edwsmith) → review+
|
|
Assignee | |
Comment 5•14 years ago
|
||
flash.system.System has flash specific stuff in it, I suppose it could inherit from the shell's System but then our System class has lots of stuff flash doesn't necessarily want. I guess we could split SystemClass into SharedSystemClass and ShellSystemClass and have the player inherit from SharedSystemClass.
|
|
Assignee | |
Comment 6•14 years ago
|
||
will leave the shell/player synchronization issue for another day: http://hg.mozilla.org/tamarin-redux/rev/f1f097296a49
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•