Closed
Bug 523878
Opened 15 years ago
Closed 15 years ago
XHR not taken from visible window when runtime's window is hidden
Categories
(Mozilla Labs :: Jetpack Prototype, defect, P1)
Mozilla Labs
Jetpack Prototype
Tracking
(Not tracked)
RESOLVED
FIXED
0.6
People
(Reporter: adw, Assigned: adw)
Details
Attachments
(1 file)
588 bytes,
patch
|
Details | Diff | Splinter Review |
|xhr| is set once in the |Extension.isHidden| conditional but then immediately set again outside the conditional. Probably you just forget the else. I noticed this when I was testing Twitter in 3.6 and trunk on OS X. The XHR's authentication prompt doesn't appear on the main window. It floats by itself and is only visible via Expose, and the result is that Firefox appears locked up. Interestingly, on 3.5 the prompt does appear on the main window, which is probably why this wasn't caught sooner.
Attachment #407799 -
Flags: review?(avarma)
Comment 1•15 years ago
|
||
Thanks! Pushed in rev e382b1895f12.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•14 years ago
|
Attachment #407799 -
Flags: review?(avarma)
You need to log in
before you can comment on or make changes to this bug.
Description
•