523980 - Bad escaping in xpinstall dialog

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Justin Scott [:fligtar]]

I know we've fixed this bug before (years ago), but it seems to have resurfaced.

http://www.squarefree.com/temp/poor-escaping.png

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Attaching screenshot locally

Comment 2

[Fred Wenzel [:wenzel]]

Probably due to the install button rewrite?

Comment 3

[Ryan Doherty (:rdoherty)]

(In reply to comment #2)
> Probably due to the install button rewrite?

Most likely, yes. Now that it's been rewritten, it should be super easy for anyone else to edit the code! :)

Comment 4

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

There you go.

Comment 5

[Ryan Doherty (:rdoherty)]

Comment on attachment 408029 [details] [diff] [review]
Patch, rev. 1

Looks good and works, thanks for fixing this Wenzel!

Comment 6

[Fred Wenzel [:wenzel]]

Excellent. r54084.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using https://preview.addons.mozilla.org/en-US/firefox/addon/3481 and https://preview.addons.mozilla.org/en-US/firefox/addon/8206.