Closed
Bug 524219
Opened 15 years ago
Closed 15 years ago
Renaming a tag in the Library doesn't show its new name until the Library gets reopened
Categories
(Firefox :: Bookmarks & History, defect, P2)
Firefox
Bookmarks & History
Tracking
()
VERIFIED
FIXED
Firefox 3.7a1
Tracking | Status | |
---|---|---|
status1.9.2 | --- | beta2-fixed |
People
(Reporter: whimboo, Assigned: asaf)
References
Details
(Keywords: regression, verified1.9.2, Whiteboard: [3.6b1])
Attachments
(1 file)
3.83 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b1) Gecko/20091014 Firefox/3.6b1 Renaming a tag inside the Library doesn't update its name until the Library is reopened. Steps: 1. Open the Library 2. Select any bookmark and add the tag "test" 3. Expand the tags container and select the tag "test" 4. Change its name 5. Click somewhere outside of the textbox After step 5 the tag still shows its old name.
Flags: blocking-firefox3.6?
Reporter | ||
Comment 1•15 years ago
|
||
Oh, and that happens on all platforms for me.
OS: Mac OS X → All
Whiteboard: [3.6b1]
Comment 2•15 years ago
|
||
I am not able to reproduce this using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b1) Gecko/20091019 Firefox/3.6b1 - Henrik it looks as if you are using the first beta build - can you try the second build?
Reporter | ||
Comment 3•15 years ago
|
||
It doesn't matter. The same happens in todays nightly too.
Comment 4•15 years ago
|
||
i suppose could be a regression from bug 498130. We should check the builds before and after it landed.
Comment 5•15 years ago
|
||
Marco, you're right. this regressed within http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e109f9a3b6ee&tochange=149c3820e8a8 (i only have hourly builds before/after the 1st landing of that patch, but that shouldn't matter).
Blocks: 498130
Keywords: regressionwindow-wanted
Reporter | ||
Comment 6•15 years ago
|
||
(In reply to comment #5) > Marco, you're right. > this regressed within > http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e109f9a3b6ee&tochange=149c3820e8a8 The patch has been written by Asaf. Lets cc him. Thanks for checking the range.
Comment 7•15 years ago
|
||
Mano, can you fix?
Flags: blocking-firefox3.6? → blocking-firefox3.6+
Priority: -- → P2
Updated•15 years ago
|
Assignee: nobody → mano
Assignee | ||
Updated•15 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 8•15 years ago
|
||
Attachment #408699 -
Flags: review?(mak77)
Updated•15 years ago
|
Attachment #408699 -
Flags: review?(mak77) → review+
Comment 9•15 years ago
|
||
Comment on attachment 408699 [details] [diff] [review] patch >diff --git a/toolkit/components/places/tests/unit/test_419731.js b/toolkit/components/places/tests/unit/test_419731.js >- root.containerOpen = false; >+ theTag.containerOpen = false; nit: close root Thanks!
Updated•15 years ago
|
Flags: in-testsuite?
Assignee | ||
Comment 10•15 years ago
|
||
mc: 448f4866de46 192: b5ce20227bab
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
status1.9.2:
--- → beta1-fixed
Flags: in-testsuite? → in-testsuite+
Resolution: --- → FIXED
Comment 11•15 years ago
|
||
b1 has already a separate branch so this is final-fixed thanks.
Reporter | ||
Comment 12•15 years ago
|
||
Verified fixed on trunk and 1.9.2 with builds on OS X: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a1pre) Gecko/20091101 Minefield/3.7a1pre ID:20091101031119 Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2b2pre) Gecko/20091030 Namoroka/3.6b2pre ID:20091030043032
You need to log in
before you can comment on or make changes to this bug.
Description
•