524461 - CC* factories should halt build if running of client.py fails

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

Currently if client.py fails, the CC* factories in buildbotcustom don't halt the build. This means we go on to compile and possibly run unit tests etc, when really we should just abort as there's no point in doing something else.

Patch attached to set haltOnFailure (only affects comm-central builds).

Comment 1

[Philippe M. Chiasson (:gozer)]

Comment on attachment 408389 [details] [diff] [review]
The fix

Good idea, even if sometimes, if client.py fails to pull (instead of failing to clone), the build could have continued. But since that's just hiding hg issues, I think going red right away makes more sense.

Only nit is that since you alter the description/descriptionDone, might as well make it the same everywhere (the last ShellCommand invocation doesn't have them)

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix v2

Same fix with gozer's comment about adding the description and descriptionDone parameters to the last ShellCommand.

Comment 3

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/build/buildbotcustom/rev/4314604fdda6

I'll let gozer and KaiRo pick this up when they have time to update buildbotcustom.