524490 - js/src/trace-test/tests/sunspider/check-date-format-xparb.js is broken everywhere but the US

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

The results depend on when your locale enters and leaves Daylight Savings Time.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: v1

The answer is not to check so much.

This loses a bunch of phony coverage in favor of a small amount of real coverage. I'd rather not spend time improving it further.

Comment 2

[Jason Orendorff [:jorendorff]]

Closely related to bug 515254.

Comment 3

[Nicholas Nethercote [inactive]]

As a non-US-west-coaster, I say "hear hear" to this patch.  But a comment in the code briefly explaining why we're not doing exact matching would be nice.

Comment 4

[Jason Orendorff [:jorendorff]]

Comment on attachment 408417 [details] [diff] [review]
v1

I'll add this comment.

// No exact match because the output depends on the locale's time zone. See bug 524490.

Comment 5

[Andreas Gal :gal]

Comment on attachment 408417 [details] [diff] [review]
v1

SunSpider. A constant source of embarrassment.

Comment 6

[Jason Orendorff [:jorendorff]]

http://hg.mozilla.org/tracemonkey/rev/4b5938c3b527

Comment 7

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/4b5938c3b527

Comment 8

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/d56452cb476b

Comment 9

[Samuel Sidler (old account; do not CC)]

These bugs landed after b4 was cut. Moving flag out.