524714 - Using Mail toolbar > Customize changes current searchMode to 'global' with unexpected results if quickfilter was set (customization palette, quicksearch)

Status: RESOLVED INVALID

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Thomas D. (:thomas8)]

After closing main toolbar customization dialogue with "Done" (only way to close it), even without any changes, we are reverting the searchInput.searchMode from whatever mode it currently has to the default "global" ("Search all messages"). Which is already wrong. Worse however, we don't remove existing traditional quick filters, which means user will see filtered set of messages (or no messages) although there is no filter set in the quick search bar.

This is a variant of Bug 517200: [faceted search] Can't remove quick filter after switching from an active traditional Quicksearch filter to "Search all messages" (can cause blank message list although no filter set)

STR
1 on a folder view, have "Subject, From, or Recipient" as your default quick filter
2 enter search term that matches only a few messages
3 from mail toolbar context menu, do "customize..."
4 Don't customize anything, click "done" to leave customization dlg (without having changed anything!)

Actual
- current filter mode ("Subject, From, or Recipient") is replaced by "Search all messages" global filter mode (bug, we shouldn't override user's choice without reason)
- searchwords are removed from search input, BUT
- existing view filter ("Subj, From, or Rec. contains "searchword") is NOT removed from the view
--> only few or no filtered results are shown, although there is no filter set
--> no intuitive way of removing the view filter (workarounds only, like changing folder or search mode)

Expected
- customization shouldn't change anything that is unrelated to the actual customization
- unless explicitly told, we shouldn't override user's searchMode
(just leave it at "Subject, From, or Rec." in our example)
- unlesss explicitly told, we shouldn't remove the searchwords, either
- if for whatever bad reasons we really wanted or needed to reset the searchMode to 'global' and thus remove the filter, we'd also have to remove the actual filtering from folder view (patch of bug 517200 knows how).

Comment 1

[Wayne Mery (:wsmwk)]

invalid as of version 3.1?

Comment 2

[Wayne Mery (:wsmwk)]

Thomas, Joe, do you still see this?

Comment 3

[Wayne Mery (:wsmwk)]

No longer relevant with new unified toolbar