524732 - jsreftests - js1_5/Regress/regress-344804.js | js1_5/Scope/regress-181834.js FAIL

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bob Clary [:bc] (inactive)]

jsreftests - js1_5/Regress/regress-344804.js | js1_5/Scope/regress-181834.js are failing on Windows with Attempt to call default method on object with no default method.

Comment 1

[Bob Clary [:bc] (inactive)]

http://hg.mozilla.org/tracemonkey/rev/930e7e7e9217
mark as failing for windows browser. This is not reproducible in my local vm.

Comment 2

[Bob Clary [:bc] (inactive)]

jorendorff: do you have any idea why this would fail on the unit test machines but not locally?

Comment 3

[Bob Clary [:bc] (inactive)]

Attachment: patch to reenable tests

Comment 4

[Benjamin Smedberg]

Comment on attachment 417548 [details] [diff] [review]
patch to reenable tests

ok, let's try it, and we can at least move back to random-if if we've just made it intermittent

Comment 5

[Benjamin Smedberg]

reverted to random-if because of failures reappearing today: http://hg.mozilla.org/mozilla-central/rev/3b4baf256382

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

In these two tests (and no other tests in jsreftest), we also hit the assertion:

###!!! ASSERTION: Shouldn't ever call this directly!: 'Not Reached', file e:/builds/moz2_slave/mozilla-central-win32-debug/build/dom/plugins/PluginScriptableObjectParent.cpp, line 327

They hit the assertion every time in Windows debug builds, and they also seem to be failing every time.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

They pass locally. Going to push a patch to try to see what happens if I re-enable them for all platforms.

js/src/tests/js1_5/Regress/regress-344804.js
BUGNUMBER: 344804
STATUS: Do not crash iterating over window.Packages
 PASSED! Do not crash iterating over window.Packages

js/src/tests/js1_5/Scope/regress-181834.js
BUGNUMBER: 181834
STATUS: Testing scope
 PASSED! Section 1 of test -
 PASSED! Section 2 of test -
 PASSED! Section 3 of test -
 PASSED! Section 4 of test -
 PASSED! Section 5 of test -
 PASSED! Section 6 of test -

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Attachment: Updated patch

Try likes it too. I had multiple runs triggered and all completed without issue.
https://tbpl.mozilla.org/?tree=Try&rev=bb9dd1ff3610

Comment 9

[Bob Clary [:bc] (inactive)]

Comment on attachment 577177 [details] [diff] [review]
Updated patch

Review of attachment 577177 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. Can you get one of the JS team to piggy back this patch during a landing?

Comment 10

[Daniel Holbert [:dholbert]]

Landed:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/8dd8c2258cc2

Comment 11

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/8dd8c2258cc2