524965 - Tabsposé should only be tab-to-able when the OS is set to "All controls"

Status: RESOLVED WONTFIX

(Camino Graveyard :: Tabbed Browsing, defect)

Description

[Stuart Morgan]

It's odd to have Tabsposé be keyboard-enabled when nothing else is; we should be honoring the OS pref. I meant to do that, but it slipped my mind once I got it working in the All-controls case.

This wouldn't be a problem if we were using NSButtons, of course :P

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On a correctness level, I agree with you.

On the other hand, we enable tabbing to all controls inside the content area by default because people expect them to be tabable from the past and they're confused otherwise.  This isn't the content area, certainly, but it lives in the same place (and our other non-content area views that live where the content area does happen to be controls that are tabable by default [table and outline views]).

Also, I think once we ship 2.0 with it being tabable, it will be hard to undo without outcry.

Comment 2

[Stuart Morgan]

I think some kind of keyboard interface like I mentioned in the "Return" bug is a good idea, I just don't think we should use the keyboard-accessibility model (tab to select, control focus ring) for it.

Comment 3

[Stuart Morgan]

Hm, Finder does allow tab, so maybe if we do bug 524906 this should still be WONTFIX.

Comment 4

[Stuart Morgan]

Yeah, I don't think this is a good idea any more; we should just have a sexier selection effect and improve discoverability of keyboard navigation (bug 524906).