525701 - X-Osso-Service doesn't match Vendor.Name in application.ini

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Fennec 1.0b5 is crashing when launched via the Task Launcher UI because we changed the X-Osso-Service in the fennec.desktop.in file to "mozilla.fennec", but the code in nsNativeAppSupport uses "Mozilla.Fennec", pulled from our application.ini

We have two choices: revert the X-Osso-Service entry to "Mozilla.Fennec" or change the code in nsNativeAppSupport to lowercase the strings it uses to create the service name.

I quick look at other apps seems to suggest lowercase service names are the norm, but it was a quick look.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

nsNativeAppSupport code in question:
http://mxr.mozilla.org/mozilla-central/source/toolkit/xre/nsNativeAppSupportUnix.cpp#300

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Lowercase the application service name before initializing.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 409561 [details] [diff] [review]
patch

Benjamin - this is a Maemo only change. We are subverting the Vendor/Name data in application for yet another strange  use.

After googling and looking at some other Maemo apps, I think forcing the application service name is more platform appropriate.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

... forcing the application service name to lowercase is ...

Comment 5

[Doug Turner (:dougt)]

Comment on attachment 409561 [details] [diff] [review]
patch

This is safe from a osso point of view, and ToLowerCase is being used throughout the codebase.  Oh, i also added this code originally... probably should have forced case at that point.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed m-c:
http://hg.mozilla.org/mozilla-central/rev/eac3ed4a8edc

pushed m-192:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/353ad892c2b5

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b2pre) Gecko/20091102 Namoroka/3.6b2pre Fennec/1.0b5

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.2b2pre) Gecko/20091102 Namoroka/3.6b2pre Fennec/1.0b5