526436 - AIX Compilation error for 3.7a1pre source js/src/jsvector.h", line 677.21: 1540-0274 (S) The name lookup for "PointerRangeSize" did not find a declaration

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Shailen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4) Gecko/20091016 Firefox/3.5.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4) Gecko/20091016 Firefox/3.5.4

While compiling Mozilla Firefox source for 3.7a1pre, getting
the below error.

"/home/firefox/mozilla-central/js/src/jsvector.h", line 677.21: 1540-0274 (S) The name lookup for "PointerRangeSize" did not find a declaration.
"/home/firefox/mozilla-central/js/src/jsvector.h", line 677.21: 1540-1292 (I) Static declarations are not considered for a function call if the function is not qualified.
"/home/firefox/mozilla-central/js/src/jsvector.h", line 674.1: 1540-0700 (I) The previous message was produced while processing "js::Vector<unsigned short,32,js::ContextAllocPolicy>::append<unsigned short>(const unsigned short *, const unsigned short *)".
"/home/firefox/mozilla-central/js/src/jsarray.cpp", line 1374.1: 1540-0700 (I) The previous message was produced while processing "array_toSource(JSContext *, uintN, jsval *)".
"/home/firefox/mozilla-central/js/src/jsvector.h", line 677.21: 1540-0274 (S) The name lookup for "PointerRangeSize" did not find a declaration.
"/home/firefox/mozilla-central/js/src/jsvector.h", line 677.21: 1540-1292 (I) Static declarations are not considered for a function call if the function is not qualified.
"/home/firefox/mozilla-central/js/src/jsvector.h", line 674.1: 1540-0700 (I) The previous message was produced while processing "js::Vector<unsigned short,32,js::ContextAllocPolicy>::append<char>(const char *, const char *)".
"/home/firefox/mozilla-central/js/src/jsvector.h", line 418.13: 1540-0700 (I) The previous message was produced while processing "js::js_AppendLiteral<unsigned short,32,js::ContextAllocPolicy,3>(Vector<unsigned short,32,js::ContextAllocPolicy> &, const char (&)[3])".
"/home/firefox/mozilla-central/js/src/jsarray.cpp", line 1454.18: 1540-0700 (I) The previous message was produced while processing "array_toSource(JSContext *, uintN, jsval *)".
"/home/firefox/mozilla-central/js/src/jscntxt.h", line 1580.44: 1540-1281 (W) "offsetof" cannot be applied to "struct JSContext".  It is not a POD (plain old data) type.
gmake[1]: *** [jsarray.o] Error 1


Reproducible: Always

Steps to Reproduce:
1. Build Mozilla Firefox 3.7a1pre build on AIX with Gnome RPMS of 64 bit
version.

2.
3.
Actual Results:  
Build fails with the above error.


Expected Results:  
No build failure

Comment 1

[Shailen]

Attachment: Patch V 1

I checked with compiler team for this issue and below is the explanation I
received for the compiler behaviour.

' In the C++ Standard (ISO/IEC 14882), section 14.6.4.2 "Candidate functions"
describes that: for an unqualified function call that depends on a template
parameter, only function declarations with external linkage from the template
definition context should be found. 

 In this scenario the "static" function results in internal linkage and
therefore cannot be found. 

Approaches
1. One solution is to make the function non-static by removing "static".

2. Alternatively we may make the function-call qualified. ' 

The patch submitted has taken first approach of making the function non-static by removing static since the 2nd approach does not resolve the compilation error.

Comment 2

[Marco Bonardo [:mak]]

forwarding review, i'm not a js peer.

Comment 3

[Marco Bonardo [:mak]]

Comment on attachment 410175 [details] [diff] [review]
Patch V 1

correcting request

Comment 4

[Shailen]

Can you please review the patch and let me know if anything needs to be changed.

Comment 5

[Shailen]

Can you please review the patch ?

Comment 6

[Shailen]

can someone review the patch please?

Comment 7

[Luke Wagner [:luke]]

Comment on attachment 410175 [details] [diff] [review]
Patch V 1

Hi Shailen, I'll get right on it; sorry for the delays.

Comment 8

[Luke Wagner [:luke]]

Comment on attachment 410175 [details] [diff] [review]
Patch V 1

Oh right, how could I have forgotten Section 14.6.4.2 ;)  Thank you for investigating the source of this compiler error!  Could you also remove the static from RoundUpPow2 (above) since it may later be looked up in an argument-dependent context?

Comment 9

[Shailen]

Attachment: Revised patch

Comment 10

[Reed Loden [:reed]]

Luke isn't a JS peer, according to http://www.mozilla.org/about/owners.html#javascript, so removing checkin-needed until a JS owner/peer can review the patch.

Comment 11

[Reed Loden [:reed]]

(In reply to comment #10)
> Luke isn't a JS peer, according to
> http://www.mozilla.org/about/owners.html#javascript, so removing checkin-needed
> until a JS owner/peer can review the patch.

As per bug 526446, comment #14, Luke is a peer, so re-adding checkin-needed.

Comment 12

[Reed Loden [:reed]]

http://hg.mozilla.org/mozilla-central/rev/1d4355b162e6

Comment 13

[Uli Link (:ul-mcamafia)]

Comment on attachment 418480 [details] [diff] [review]
Revised patch

This bug isn't fixed on mozilla-1.9.2 branch yet.

Comment 14

[Uli Link (:ul-mcamafia)]

Risc: none as fixed on trunk/moz193 for more than a year.
So renewing branch approval request.

Comment 15

[Daniel Veditz [:dveditz]]

Comment on attachment 418480 [details] [diff] [review]
Revised patch

Approved for 1.9.2.14, a=dveditz for release-drivers

Comment 16

[Daniel Veditz [:dveditz]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/19d9407e4359