526663 - [Win7] Firefox shortcut icon remains in taskbar after uninstalling application

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Marcia Knous [:marcia]]

Attachment: Screenshot of shortcut window

Seen while running the latest 1.9.2 nightly.

STR:
1. Install Namoroka build in the default directory.
2. Pin the app to the taskbar.
2. Run the uninstaller.

See the attached screenshot. We leave an icon behind in the taskbar after the uninstaller is run.

I tried the same STR using Google Chrome and that app did not leave anything behind.

Comment 1

[Marcia Knous [:marcia]]

Attachment: Screenshot of shortcut icon

Comment 2

[Jim Mathies [:jimm]]

I'm not sure if we can delete this, since it was based on a user action.

Comment 3

[Robert Strong (they/them - no direct email)]

We *might* be able to since there are a few hacks out there for working around the intentional lack of ability for installers to add / remove the taskbar shortcuts.

Comment 4

[James May [:fowl2]]

> Any shortcut installed by an application might have been subsequently pinned by the user, and there is no way for an application to know this. Therefore, we recommend that, during uninstallation, all applications call IStartMenuPinnedList::RemoveFromList  on each shortcut they installed.

http://msdn.microsoft.com/en-us/library/bb774817.aspx

Comment 5

[Jim Mathies [:jimm]]

(In reply to comment #4)
> > Any shortcut installed by an application might have been subsequently pinned by the user, and there is no way for an application to know this. Therefore, we recommend that, during uninstallation, all applications call IStartMenuPinnedList::RemoveFromList  on each shortcut they installed.
> 
> http://msdn.microsoft.com/en-us/library/bb774817.aspx

Woot! We can add that to the uninstall. Thanks James!

Comment 6

[Jim Mathies [:jimm]]

Attachment: patch v.1

Comment 7

[Jim Mathies [:jimm]]

Attachment: patch v.2

Comment 8

[Jim Mathies [:jimm]]

       ShellLink::GetShortCutTarget "$QUICKLAUNCH\$R8"
       Pop $R5
       StrCmp "$INSTDIR\${FileMainEXE}" "$R5" +1 -7
+      ApplicationID::UninstallPinnedItem "$QUICKLAUNCH\$R8"
       Delete "$QUICKLAUNCH\$R8"

Rob, should I add pops after all of these UninstallPinnedItem calls?

Comment 9

[Robert Strong (they/them - no direct email)]

Definitely if they change the registers from what they were before calling the macro.

Comment 10

[Jim Mathies [:jimm]]

Attachment: updated patch v.2

Added Pop's to remove the result of ApplicationID::UninstallPinnedItem from the stack.

Comment 11

[Jim Mathies [:jimm]]

http://hg.mozilla.org/mozilla-central/rev/aba944ea85dd