526871 - avmshell should print out what type of build it is when displaying info

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, enhancement)

Description

[Chris Peyer]

The build files always generate the executable avmshell regardless of configuration.  In order to help our test scripts, it would be useful for the avmshell to print out something like this in the info string:

avmplus release-debugger shell 1.4 build 2984:89e6ebc7bad6

The most important configs would be:
release = avmshell
release-debugger = avmshell_s
debug = avmshell_d
debug-debugger = avmshell_sd

Comment 1

[Chris Peyer]

Attachment: Output avm type in info string

Comment 2

[Rick Reitmaier]

Attachment: cleanup...untested

Cleanup up the previous ifdef tangle a bit.

Comment 3

[Rick Reitmaier]

Comment on attachment 410614 [details] [diff] [review]
Output avm type in info string

let try to remove the ifdef from the cpp file.

Attached revised patch untested

Comment 4

[Chris Peyer]

Attachment: Change order of wording from last patch

Tested locally - works as expected.

Comment 5

[Chris Peyer]

Attachment: Determine avmshell type in runtestBase based on build type

Brent - Also wanted your feedback on how the string should be ordered.  It is now outputting the shell type between the shell version and build.

e.g:
avmplus shell 1.4 release-debugger build 1234:asldfhjeowi

Comment 6

[Chris Peyer]

Attachment: patch with actual changes to runtestBase

Comment 7

[Chris Peyer]

Pushed to redux 3012:6bbb910d0e53