526892 - Add a preference to control the delay when doing password echoing

Status: NEW

(Core :: DOM: Editor, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Bug 514212 added password echoing. The current delay is 600ms, which might be too short. Regardless, we could add a preference to control the timeout duration

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

GTK calls it "gtk-entry-password-hint-timeout"

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

How about "editor.password_hint.timeout"

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

I guess the editor prefs don't use underscores, so "editor.passwordHint.timeout"

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Mark Finkle (:mfinkle) (use needinfo?) from comment #1)
> GTK calls it "gtk-entry-password-hint-timeout"

Sounds like that LookAndFeel for GTK should refer the value instead of using 600.

(And perhaps, we should make LookAndFeel::GetEchoPassword() customizable for automated tests and allow to debug even on Windows and macOS.

Comment 5

[Makoto Kato [:m_kato]]

(In reply to Masayuki Nakano [:masayuki] (JST, +0900) from comment #4)
> (In reply to Mark Finkle (:mfinkle) (use needinfo?) from comment #1)
> > GTK calls it "gtk-entry-password-hint-timeout"
> 
> Sounds like that LookAndFeel for GTK should refer the value instead of using
> 600.

There is GetPasswordMaskDelayImpl to manage echo timeout by bug 772327 that is added for Android.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Yeah, I meant that GTK should refer system settings instead of referring only pref.