Closed Bug 526953 Opened 15 years ago Closed 15 years ago

rename nsPluginInstanceOwner's "mOwner" member variable to something less confusing

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jaas, Assigned: jaas)

Details

Attachments

(1 file)

Attached patch fix v1.0Splinter Review
nsPluginInstanceOwner has a member variable named "mOwner" which is surprisingly confusing in the context of nsObjectFrame.cpp. In that context one thinks of the "owner" as the nsPluginInstanceOwner object, but in fact it is a reference to the nsObjectFrame.
Attachment #410717 - Flags: review?(roc)
Attachment #410717 - Flags: review?(roc) → review?(jst)
Attachment #410717 - Flags: superreview+
Attachment #410717 - Flags: review?(jst)
Attachment #410717 - Flags: review+
Comment on attachment 410717 [details] [diff] [review]
fix v1.0

Good cleanup! r+sr=jst
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/e980db595f62
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: