Closed
Bug 527027
Opened 15 years ago
Closed 15 years ago
date_makeDate regression
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
status1.9.2 | --- | beta5-fixed |
blocking1.9.1 | --- | .6+ |
status1.9.1 | --- | .6-fixed |
People
(Reporter: igor, Assigned: igor)
References
Details
(Keywords: regression, Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
712 bytes,
patch
|
brendan
:
review+
|
Details | Diff | Splinter Review |
In the patch for bug 524121 I regressed date_setDate so it no longer sets the vp out parameter to NaN when argc == 0. The following test case explicitly checks for that: function check_nan(x) { if (typeof x == "number" && isNaN(x)) return; throw Error("The result is not NaN: "+uneval(x)); } var d = new Date(); check_nan(d.setTime()); check_nan(d.setYear()); check_nan(d.setFullYear()); check_nan(d.setUTCFullYear()); check_nan(d.setMonth()); check_nan(d.setUTCMonth()); check_nan(d.setDate()); check_nan(d.setUTCDate()); check_nan(d.setHours()); check_nan(d.setUTCHours()); check_nan(d.setMinutes()); check_nan(d.setUTCMinutes()); check_nan(d.setSeconds()); check_nan(d.setUTCSeconds()); check_nan(d.setMilliseconds()); check_nan(d.setUTCMilliseconds());
Assignee | ||
Comment 1•15 years ago
|
||
The bug is a regression from a bug that is 1.9.2 blocker.
Severity: critical → normal
Flags: blocking1.9.2?
Assignee | ||
Comment 2•15 years ago
|
||
This fixes the regression that I did when refactored SetDateToNan logic.
Attachment #410879 -
Flags: review?(brendan)
Updated•15 years ago
|
Attachment #410879 -
Flags: review?(brendan) → review+
Assignee | ||
Comment 3•15 years ago
|
||
https://hg.mozilla.org/tracemonkey/rev/3428c42d7116
Whiteboard: fixed-in-tracemonkey
Updated•15 years ago
|
Flags: blocking1.9.2? → blocking1.9.2+
Assignee | ||
Comment 4•15 years ago
|
||
The issue is fixed on 1.9.1 as the back ported patch for the bug 524121 includes this fix.
Comment 5•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/3428c42d7116
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 6•15 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/a13325026f28
status1.9.2:
--- → final-fixed
Comment 7•15 years ago
|
||
These bugs landed after b4 was cut. Moving flag out.
You need to log in
before you can comment on or make changes to this bug.
Description
•