Closed
Bug 527030
Opened 15 years ago
Closed 15 years ago
[FyFx] Fix site for chinese locale
Categories
(Webtools Graveyard :: Five Years of Firefox, defect)
Webtools Graveyard
Five Years of Firefox
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: morgamic, Assigned: jguo)
Details
Attachments
(4 files, 1 obsolete file)
We need to fix the sharethis section to change based on whether or not it's served in china.
Reporter | ||
Updated•15 years ago
|
Summary: Fix site for chinese locale → [FyFx] Fix site for chinese locale
Hey guys: Two things will need to happen for the cn-ZH version... 1) Customize the "sharethis" widget under the video. I've asked Jack to let me know if there is a Chinese-specific widget he'd like to use or if wants to pick from ShareThis' list of options. Waiting on confirmation. 2) The "Wish Firefox a Happy Birthday" block: We need to swap out the services here and change the copy slightly. -- Twitter: http://t.sina.com.cn/ -- Facebook: http://www.douban.com/group/Firefox/ Final copy would be: Wish Firefox a Happy Birthday! Copy and paste one of these messages below, or write your own. * Happy 5th birthday, Firefox! >> Sina * Remember what the Web was like in 2004? Thanks for changing that, Firefox! >> Sina * Celebrate 5 years of making the Web better with Firefox Tweet this! » Sina * Write your own message » Sina Douban Join us on Douban (http://www.douban.com/group/Firefox/) Jack: Can you please do the following :) * Update the copy on this block so it says "copy & paste" * Provide an answer on whether you want to use a specific Chinese share widget or pick a few of the ShareThis supported-services * Provide a sina logo or button to replace the twitter button we have Thanks so much and please let me know if you have any questions. Mary
Reporter | ||
Comment 2•15 years ago
|
||
Carlos, do you guys have time to work on this?
Reporter | ||
Updated•15 years ago
|
Assignee: nobody → carlos.ferro
Comment 3•15 years ago
|
||
Sure, we'll have to wait for the needed input from Jack and we can pick up. One question: We haven't worked with those sites before so not sure what the parameters to add to the URL for the predefined message (if needed as we did for Twitter/FB) would be? Is there English documentation available?
Hey there: Jack said we couldn't do the predefined messages with Sina. I added "copy & paste" to the copy above it to make that clear. Thanks!
3 buttons:- sina to replace twitter douban to replace facebook renren is for video sharing, sina mini-blog also can share video
i am sorry for the late, wasn't able to connect to internet in last weekend. * the current translate works with "copy & paste" * yes, please use http://www.renren.com for video sharing * i uploaded 3 buttons above.
Comment 7•15 years ago
|
||
Jack: Should we use renren instead of digg?
Comment 8•15 years ago
|
||
Just to clarify, do I need to remove the "share this" functionality and implement renden?
Comment 9•15 years ago
|
||
Hi Jack and Mary I have made the following cn-ZH updates: Video Share Section: Twitter icon replaced with Sina icon url: http://t.sina.com.cn/ Douban icon replaced with Douban icon url: http://www.douban.com/group/Firefox/ Digg: Could you confirm us if we need to place another url/icon or just remove this button? Share this widget replaced with renren icon url: http://www.renren.com/ (Should this url have some parameter in order to share the video?) Birthday Wishes Section: Twitter icon replaced with Sina icon url: http://t.sina.com.cn/ Could you please update the label "Twitter" in the po file? Own message facebook replaced with douban icon url: http://www.douban.com/group/Firefox/ Own Twitter message replaced with sina icon url: http://t.sina.com.cn/ For Become a fan on Facebook and follow our tweets could you update the labels in the po files? We updated such urls with: http://www.douban.com/group/Firefox/ url: http://t.sina.com.cn/
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Assignee: carlos.ferro → jguo
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 10•15 years ago
|
||
Thanks so much. I need Jack to confirm.
Reporter | ||
Comment 11•15 years ago
|
||
Jack? Can you please reply?
Comment 12•15 years ago
|
||
Jack: the translation still mentions Twitter and Facebook: <http://fyfx.stage.mozilla.com/zh-CN/>. Can you please update it and commit to svn or attach to this bug? Thanks.
Comment 13•15 years ago
|
||
Bug 527720 and bug 527721 covered creating a production branch in svn from which we can serve the site on the production server. Please read bug 527720 comment 0 to see how this was related to this bug.
Assignee | ||
Comment 14•15 years ago
|
||
just realized that someone modified my translation later...mine was neutral. I uploaded here. Thanks.
Assignee | ||
Comment 15•15 years ago
|
||
Comment 16•15 years ago
|
||
Thank you Jack. It looks like you were basing on an old version of the en-US reference. I merged your messages.po file with the most recent messages.pot file (en-US reference). Attached it the result. There are 10 untranslated strings and 14 fuzzy ones. Can you please translate the missing/fuzzy strings and attach the new file here? Thanks!
Attachment #411601 -
Attachment is obsolete: true
Assignee | ||
Comment 17•15 years ago
|
||
Thank you Stas... please see if this version works
Comment 18•15 years ago
|
||
Hi Jack, I noticed that the "SpreadFirexox" button layout is broken... I have checked the current po file and there is an extra "a" tag there. Could you please apply these changes? Current broken version: "<a rel=\"section\" href=\"http://www.spreadfirefox.com/\"><span>转到</" "span><span class=\"spreadfirefox-text\"> SpreadFirefox</span></a>" Should be: "<span>转到</span><span class=\"spreadfirefox-text\"> SpreadFirefox</span>" If is not a problem, I can modify the file. Please let me know if you are ok. with this. thank you!
Comment 19•15 years ago
|
||
i updated the translation in r55908. I also fixed the string Andres mentioned in comment 18 above. I had to fix a couple of more string because there were still using full URLs instead of "%s" variables. I unfuzzied a couple of strings assuming that Jack jad reviewed them but didn't change the "fuzzy" status. Please verify on stage if all is OK: http://fyfx.stage.mozilla.com/zh-CN/ (might take a couple of more minutes to update).
Assignee | ||
Comment 20•15 years ago
|
||
many thanks Stas...I checked staging site. there are two characters need to be deleted. I uploaded a screen shot file above. Could you help with delete them directly? except this, the page is perfect ok.
Comment 21•15 years ago
|
||
Thanks Jack. Committed in r55974. http://fyfx.stage.mozilla.com/zh-CN/ looks OK, as per your screenshot from comment 20. I'm going to ask the IT to update the production server. Thanks!
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
Comment 22•15 years ago
|
||
This went live yesterday (bug 528178). Please verify at <http://www.spreadfirefox.com/5years/zh-CN/>. Thanks.
Comment 23•15 years ago
|
||
Jack is your man for verification :) Thanks so much fo everyone's work!
You need to log in
before you can comment on or make changes to this bug.
Description
•