527638 - Live Bookmarks do not load and reload/update

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Antti Tervasmäki]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091109 Minefield/3.7a1pre Firefox/3.5.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091109 Minefield/3.7a1pre Firefox/3.5.5

Since 20091107 nighly live bookmarks do not load or update at all. 
They work by manually reloading but other that that nothing happens.

Reproducible: Always

Steps to Reproduce:
1.Start browser
2.
3.
Actual Results:  
See live bookmarks, they have not loaded, and do not update.

Expected Results:  
Updated live bookmarks.

Trunk nightly 20091106 works nightly 20091107 and after that fails.

Comment 1

[Antti Tervasmäki]

From hourly archives:

1257510448-20091106042728-f37a407b787a-firefox-3.7a1pre.en-US.win32 is OK

1257526697-20091106085817-84125ff8a317-firefox-3.7a1pre.en-US.win32 fails

Comment 2

[(mostly gone) XtC4UaLL [:xtc4uall]]

based on comment 1:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f37a407b787a&tochange=84125ff8a317

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

based on the regrange, looks like it's me.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.0

my bad for not having double tested this.
Unfortunatly we don't have a unit test for this, and making one is hard because we force a minimum re-check time of 1.5 minutes to avoid perf problems and servers overloads. So the test would take 2 minutes to run, providing a way to bypass this would get rid of our safe limits.

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/d6ad93f972f9

Comment 6

[Antti Tervasmäki]

Works Ok again! Thanks for quick fix!

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091112 Minefield/3.7a1pre Firefox/3.5.5 - Build ID: 20091112045818