Closed Bug 527997 Opened 15 years ago Closed 15 years ago

[dashboard][shipping] diff links in pushes view should base off of accepted signoff instead of pending

Categories

(Mozilla Localizations :: Infrastructure, defect, P1)

Product:
Mozilla Localizations
Component:
Infrastructure
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Pike, Assigned: zbraniecki)

Details

Right now, if there's a pending sign-off, the diff links are wrt that sign-off instead of wrt the last accepted sign-off.

That makes reviewing sign-offs hard.
Fixing this naively (did that locally) breaks everything.

We might want to have this depend on the signoffs-factorization bug, fwiw. I'll try to hack on that one in a way that that's feasible.

I wish the pushes view wouldn't be so slow locally. We query the hell for each push loaded, apparently.
Priority: -- → P1
http://hg.mozilla.org/l10n/django-site/rev/e2bc64d33a4c

fixed it almost naively, but without breaking the foundations of the universe... I hope.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Reopening, http://bm-l10n-dashboard01/stage/shipping/pushes?locale=gl&av=fx3.5 shows a diff link on an accepted signoff. Not sure why, can you investigate?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Also, it offers a diff link if there's only one pending signoff, with from= nothing.
http://hg.mozilla.org/l10n/django-site/rev/d268b7c7fefb
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
Assignee: nobody → gandalf
Summary: [dashboard] diff links in pushes view should base off of accepted signoff instead of pending → [dashboard][shipping] diff links in pushes view should base off of accepted signoff instead of pending
You need to log in before you can comment on or make changes to this bug.