528752 - [Mac Classic] History drop-down height doesn't match full number of rows

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Stefan [:stefanh]]

The 25em height of the history drop-down makes room for about 16 rows in Mac Classic. The "about" is the problem here - when you move down to the last visible entry, the list will scroll down a couple of pixels since the height doesn't match a full number of rows.

25em equals to 16 rows + a few pixels. Now, every row is 19px high, so optionally we should have a max-height of 304px

Comment 1

[Stefan [:stefanh]]

Attachment: Fix height

Modern actually only show 15 rows, and there's also some extra space at the bottom, so all rows fit.

Comment 2

[Stefan [:stefanh]]

Karsten, this is also a comm-1.9.1 problem, so you should be able to look at it ;-)

Comment 3

[[e-mail]]

Comment on attachment 412433 [details] [diff] [review]
Fix height

How can you be sure that rows will always be 19px?

Comment 4

[Stefan [:stefanh]]

(In reply to comment #3)
> (From update of attachment 412433 [details] [diff] [review])
> How can you be sure that rows will always be 19px?

The min-height of a menuitem is 19px and the font we use here is smaller than in regular menuitems and you can't change the font-size in the OS ui.

Comment 5

[Stefan [:stefanh]]

fwiw, seems that 25.3em will also give me the height I want.

Comment 6

[[e-mail]]

Based on your figures we have 1em = 12px, so if you use 24em you should get 15 rows of 19 pixels plus 3 spare pixels, which will look similar to Modern (where we use 25em to get 16 rows of 17 pixels plus 3 spare pixels). If you don't have a border you could use 27em which would get you 17 rows plus 1 spare pixel.

Comment 7

[Karsten Düsterloh]

Given that Modern on Mac has 15 rows + some pixels, I'd prefer the 24em for Classic.

Comment 8

[Stefan [:stefanh]]

Using em will just get it "almost" right.

Comment 9

[Karsten Düsterloh]

Granted, but 15 rows à 19px would be 285px...
In either case, the number of rows should be the same for both themes, so I'm a bit unsure why this bug only covers Classic? One could argue that the Classic dropdown is more than sufficient to show its 15 entries like Modern does...

Comment 10

[Stefan [:stefanh]]

Sure, we can have 285px, I'm more concerned with not having any empty space at the bottom ;-)

Comment 11

[Karsten Düsterloh]

Comment on attachment 412433 [details] [diff] [review]
Fix height

Okay, given you make that 285px so that Classic and Modern show the same number of lines.

Comment 12

[Stefan [:stefanh]]

Attachment: make it 285px

Actually, we may want to have a different approach for trunk (since we don't support tiger, we can restyle it a bit), but I would like this to land on branch.

Comment 13

[[e-mail]]

Comment on attachment 436883 [details] [diff] [review]
make it 285px

This would be wrong on any sane OS, but fortunately this is a Mac-only file.

Comment 14

[Stefan [:stefanh]]

Comment on attachment 436883 [details] [diff] [review]
make it 285px

This is a safe ui-tweak for mac that will correct an annoyance in the history drop-down list.

Comment 15

[Stefan [:stefanh]]

http://hg.mozilla.org/comm-central/rev/2472e56b6660
http://hg.mozilla.org/releases/comm-1.9.1/rev/3ee2884da94f