529157 - Undefined subroutine &Bugzilla::Util::ThrowUserError

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I entered "-1 day" in the timeframe box for a date changed search (I was guessing at the syntax) and got the following error

"Software error:

Undefined subroutine &Bugzilla::Util::ThrowUserError called at /data/www/bugzilla.mozilla.org/Bugzilla/Util.pm line 680.

For help, please send mail to the webmaster ([e-mail]), giving this error message and the time and date of the error."

No idea if this is new with the upgrade, as I've never tried it before (always used the "view bugs filed in the last day" link which seems to be gone).

Comment 1

[Reed Loden [:reed]]

Attachment: patch - v1

Comment 2

[Frédéric Buclin]

Comment on attachment 412732 [details] [diff] [review]
patch - v1

No, this causes dependency loops. And it's a dupe anyway.

Comment 4

[Frédéric Buclin]

Wait, this error comes from SqlifyDate(), which doesn't exist upstream in Util.pm. It's a bmo bug.

Comment 5

[Reed Loden [:reed]]

Attachment: patch - v2

Comment 7

[Frédéric Buclin]

Comment on attachment 412736 [details] [diff] [review]
patch - v2

>+        require Bugzilla::Error;
>         ThrowUserError("illegal_date", { date => $str });

If you |require Bugzilla::Error| instead of use'ing it, ThrowUserError() is not imported and so it's still unknown to Bugzilla::Util. You have to write Bugzilla::Error::ThrowUserError() explicitly, despite the |require|.

Comment 8

[Reed Loden [:reed]]

Attachment: patch - v3

Comment 9

[Frédéric Buclin]

Comment on attachment 413107 [details] [diff] [review]
patch - v3

r=LpSolit

Comment 10

[Dave Miller [:justdave]]

modified Bugzilla/Util.pm
Committed revision 6718.

Comment 11

[Dave Miller [:justdave]]

this is now live in production.