Open Bug 529366 Opened 15 years ago Updated 2 years ago

nsMIMEInfoUnix.cpp fail to compile with HILDON enabled and MOZ_ENABLE_GNOMEVFS disabled

Categories

(Firefox :: File Handling, defect)

Other
Linux
defect

Tracking

()

People

(Reporter: romaxa, Unassigned)

References

Details

Attachments

(2 files, 2 obsolete files)

Attached patch Fix (obsolete) — Splinter Review
rm -f libxul.so
../../staticlib/components/libdocshell.a(nsOSHelperAppService.o): In function `nsOSHelperAppService::OSProtocolHandlerExists(char const*, int*)':
microb-engine-30000101-1.9.3-38233.9e2ab948c080/uriloader/exthandler/unix/nsOSHelperAppService.cpp:1215: undefined reference to `nsMIMEInfoUnix::HandlerExists(char const*)'
i486-pc-linux-gnu/bin/ld: libxul.so: hidden symbol `nsMIMEInfoUnix::HandlerExists(char const*)' isn't defined
i486-pc-linux-gnu/bin/ld: final link failed: Nonrepresentable section on out
Attachment #412919 - Flags: review?(sdwilsh)
Attachment #412919 - Attachment is obsolete: true
Attachment #412992 - Flags: review?(sdwilsh)
Attachment #412919 - Flags: review?(sdwilsh)
Comment on attachment 412992 [details] [diff] [review]
Better version of hildon mime handling

defined (MOZ_ENABLE_GNOMEVFS)

I think it is bad idea of wrapping into MOZ_ENABLE_GNOMEVFS just to avoid compilation on Qt
Attachment #412992 - Flags: review?(sdwilsh)
It is not clear what HILDON + Qt imples.  When more information is available, it will probably be obvious.
This patch is setting different defines in different places...
https://bugzilla.mozilla.org/attachment.cgi?id=412143&action=edit

And finally when MOZ_ENABLE_GNOMEVFS = 0 and MOZ_PLATFORM_HILDON = 1
we are getting this compilation error
Qt and Gtk it is one thing
Hildon is different thing.

cairo-qt does not mean that we are not able to use gtk or glib or other libraries... it is only gfx backend

we can have cairo-qt configuration with gnomevfs, hildon, and gtk and that should work.

I was able to compile cairo-qt configuration only with attached patch.
problem was in dgettext compilation.

dougt can you provide build error and mozconfig which you had in 528425?
I have checked this patch, and I don't have any problems with building QT with this patch.
Attachment #412992 - Attachment is obsolete: true
Attachment #413055 - Flags: review?(mozbugz)
Comment on attachment 413055 [details] [diff] [review]
Partially revert patch from bug 528425

MOZ_PLATFORM_HILDON no longer exists.
Attachment #413055 - Flags: review?(dougt) → review-
Product: Core → Firefox
Version: Trunk → unspecified
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: