529622 - JavaScript Error: "gCrashReporter is not defined" with --disable-crashreporter

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

Bug 526545 defined gCrashReporter depending on MOZ_CRASHREPORTER but uses it unconditionally.

Comment 1

[Dietrich Ayala (:dietrich)]

Attachment: fix

Comment 2

[Dietrich Ayala (:dietrich)]

checked in on trunk. blocks a blocker, so carrying over approval from the blockerness.

http://hg.mozilla.org/mozilla-central/rev/f43b6bc2165b

Comment 3

[Dietrich Ayala (:dietrich)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/a2fa721b5fdd

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is not fixed in 1.9.2 nightly builds like Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b4pre) Gecko/20091120 Namoroka/3.6b4pre ID:20091120033655

Error: gCrashReporter is not defined
Source File: chrome://browser/content/browser.js
Line: 4183

You can reproduce this error when clicking the home button in the toolbar. Trunk builds don't show that and look ok on all platforms. Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091120 Minefield/3.7a1pre ID:20091120030847

Removing final-fixed keyword.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

I don't see how this could possibly have been fixed only on trunk and not branch, given that the patch landed on both and both seem to only have one reference to gCrashReporter.

Are you using your own --disable-crashreporter builds to test or something else?

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ok, looks like bug 530266 has been wrongly duped then. I'm using nightly builds and no self-build Namoroka for daily testing purposes. Same applies for Alice. So it should be independently handled. I'll move over to bug 530266 and leave this as fixed for 1.9.2.