529741 - Port |Bug 407875 - Unprivileged users are not notified of security updates| to SeaMonkey, re-enable 'Check for Updates'

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Robert Strong (they/them - no direct email)]

I'm hoping to land bug 407875 on the 1.9.2 branch. The patches in bug 407875 should be enough to go on and don't hesitate to ping me on irc if there are any questions

Comment 1

[Robert Strong (they/them - no direct email)]

Note: Bug 529942 will move (hopefully soon) the two new attributes from nsIApplicationUpdateService2 to nsIApplicationUpdateService on trunk

Comment 2

[[e-mail]]

(In reply to comment #1)
> Note: Bug 529942 will move (hopefully soon) the two new attributes from
> nsIApplicationUpdateService2 to nsIApplicationUpdateService on trunk
Ah, the sweet smell of #ifdef ;-)

Comment 3

[Frank Wein [:mcsmurf]]

Attachment: Patch

From what I see this is everything that needs to be ported.

Comment 4

[Frank Wein [:mcsmurf]]

Attachment: Better Patch [Checkin: Comment 11]

Comment 6

[[e-mail]]

How are you expecting me to review this? I don't use nightlies.

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> How are you expecting me to review this? I don't use nightlies.

This bug had checkin-needed. But it looked like this patch needed a review first.
Doesn't it? Or who could review it?

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 416764 [details] [diff] [review]
Better Patch
[Checkin: Comment 11]


[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.3a1pre) Gecko/20091219 SeaMonkey/2.1a1pre] (2009-12-19-00-comm-central-trunk) (W2Ksp4)

This patch fixes it for me.

Comment 9

[Frank Wein [:mcsmurf]]

The patch already had sr+ ...?

Comment 10

[[e-mail]]

Comment on attachment 416764 [details] [diff] [review]
Better Patch
[Checkin: Comment 11]

r=me based on your test.

Comment 11

[Serge Gautherie (:sgautherie)]

Comment on attachment 416764 [details] [diff] [review]
Better Patch
[Checkin: Comment 11]


http://hg.mozilla.org/comm-central/rev/d87bb12163c6

Comment 12

[Robert Kaiser]

Serge, what here is supposed to block 2.0.5? I don't see any comment here that implies why it should block, that it affects 1.9.1 at all, or what the risk is to ship a 2.0.x release with this.

Until that is cleared up, canceling the request, please re-nominate with those questions answered if there is an actual good reason.

Comment 13

[Jens Hatlak (:InvisibleSmiley)]

Attachment: branch patch [Checkin: comment 16]

(In reply to comment #12)
> I don't see any comment here that implies (...) that it affects 1.9.1 at all

1. the parent bug landed on 1.9.1 as well:
<http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b9e025a5f582>
which implies two things:
 1.1. branch is/was (SM/FF) affected as well
 1.2. the Toolkit dependencies are already met on branch. I cannot really estimate the importance of the firefox-branding.js change, though.

2. with both SM 2.0(.0) release and the latest 2.0 nightly, Help>Check for Updates is grayed out if the application directory is not writable for the user who runs SeaMonkey (just checked in my Linux VM). If it is writable, or with the patch, the label is shown as normal and clickable. With the patch, if the user clicks the label, an update check is made. If an update is found but the user doesn't have write permissions to the application directory, a message is shown that explains just that.

> or what the risk is to ship a 2.0.x release with this.

I cannot answer that, only that it's probably fixed for FF but not for us.

Comment 14

[[e-mail]]

Comment on attachment 448268 [details] [diff] [review]
branch patch [Checkin: comment 16]

r=me based on code inspection; it would help if someone else could test this.

Comment 15

[Frank Wein [:mcsmurf]]

(In reply to comment #14)
> (From update of attachment 448268 [details] [diff] [review])
> r=me based on code inspection; it would help if someone else could test this.

Patch works fine, I tested it with a branch nightly build.

Comment 16

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 448268 [details] [diff] [review]
branch patch [Checkin: comment 16]

http://hg.mozilla.org/releases/comm-1.9.1/rev/76ee166a7d08