Closed Bug 529764 Opened 15 years ago Closed 15 years ago

nsPresArena.cpp failed to compile on Solaris

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
All
Solaris
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
status1.9.2 --- beta5-fixed

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

Details

Attachments

(1 file, 1 obsolete file)

patch v2
3.62 KB, patch
zwol
: review+
dbaron
: approval1.9.2+
Details | Diff | Splinter Review 
On Solaris, mmap/munmap/madivise/mprotect is a little different.
They use (char *) instead of (void *).

Also I fixed the test to make sure scratch = *(volatile unsigned char *)opaddr; is really reading.

Verified on x86/SPARC with "make check" for debug/optimized build.
Attached patch patch (obsolete) — — Splinter Review 
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED

        Attachment #413288 -
        Flags: review?(zweinberg)

    
    

    
  
Comment on attachment 413288 [details] [diff] [review]
patch

Linux and *BSD also define caddr_t, so please just change all the "void *" to "caddr_t" and then you don't need an #ifdef SOLARIS or quite so many casts.

r=zwol with that; run it through the try server before landing, this code is fragile.

        Attachment #413288 -
        Flags: review?(zweinberg) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch v2
        — 
          — Splinter Review
      

    


  

        Attachment #413288 -
        Attachment is obsolete: true

        Attachment #413376 -
        Flags: review?(zweinberg)

        Attachment #413376 -
        Flags: review?(zweinberg) → review+

    
    

    
  
Comment on attachment 413376 [details] [diff] [review]
patch v2

looks good

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/ca55552deb4c
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

    
  

        Attachment #413376 -
        Flags: approval1.9.2?

    
    

    
  
Comment on attachment 413376 [details] [diff] [review]
patch v2

a1.9.2=dbaron

        Attachment #413376 -
        Flags: approval1.9.2? → approval1.9.2+

    
    

    
  
These bugs landed after b4 was cut. Moving flag out.

    
  
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: