529855 - Need to force default bookmarks import if mobile bookmarks root doesn't exist

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Bookmarks, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Our front end code will depend on the existence of a "mobile" bookmarks root once the patch for bug 525184 lands. New profiles have this by default (it's defined in the default bookmarks file), but to support existing profiles we'll need to also check for it and then force non-destructive default bookmarks import. This also has the advantage of adding the default bookmarks for people who don't already have them.

The patch makes two changes - forces import if the mobile root doesn't exist, and changes the "aReplace" argument in our call to restoreBookmarksFromJSONString to avoid overwriting existing bookmarks.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

I'm worried about the perf impact of starting the annotation service this early on startup, but I don't think there's really any way to avoid that...

Comment 2

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mobile-browser/rev/f305d4de5ece

Comment 3

[Martijn Wargers (dead)]

I'm reassigning this to myself for adding litmus testcases for this (aakashd discussed this on irc with blassey and ted on #mobile).

Tchung mentioned this should be a FFT test.