Closed
Bug 529866
Opened 15 years ago
Closed 15 years ago
Certain search defaults don't find the "FoxVox" addon
Categories
(addons.mozilla.org Graveyard :: Search, defect, P3)
addons.mozilla.org Graveyard
Search
Tracking
(Not tracked)
VERIFIED
FIXED
5.3.1
People
(Reporter: davedash, Assigned: davedash)
Details
Attachments
(2 files)
2.15 KB,
patch
|
clouserw
:
review+
|
Details | Diff | Splinter Review |
509.77 KB,
image/png
|
Details |
From bug 528942 comment 32 > https://preview.addons.mozilla.org/en-US/firefox/search?q=foxvox > > This will get pushed. That does work with the above query string, but when you type "foxvox" into the search bar at https://preview.addons.mozilla.org/en-US/firefox/ you get no results. The query string created by the standard search box on the preview site is: https://preview.addons.mozilla.org/en-US/firefox/search?q=foxvox&cat=all&advancedsearch=1&as=1&appid=1&lver=3.5&atype=0&pp=20&pid=5&sort=&lup= That is exactly the same string as the buggy version on the live site: https://addons.mozilla.org/en-US/firefox/search?q=foxvox&cat=all&advancedsearch=1&as=1&appid=1&lver=3.5&atype=0&pp=20&pid=5&sort=&lup= So it seems the standard search form needs changing?
Assignee | ||
Comment 1•15 years ago
|
||
My suspicion is that your addon was indexed incorrectly. I'll get to the bottom of this.
Assignee: nobody → dd
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → 5.4
Assignee | ||
Updated•15 years ago
|
Flags: in-testsuite?
Assignee | ||
Comment 2•15 years ago
|
||
Both platform and max/min ver check a files status before it indexes those items. This can be problematic, for example experimental addons do not have a file status of 4 (Public) and therefore we'd lose the supported platform and supported max/min versions. The reason this wasn't done this way to begin with is that a public addon might release some versions of its addon and have them be experimental - but as far as search is concerned, that doesn't matter too much. The result now is that FoxVox is picked up by the indexer and indexed with the correct max/min versions and correct platforms. I can now find it regardless of the default search settings.
Attachment #413394 -
Flags: review?(clouserw)
Updated•15 years ago
|
Flags: in-litmus?
Comment 3•15 years ago
|
||
Comment on attachment 413394 [details] [diff] [review] Indexing supported Platform, Max/Min vers smarter any search changes scare me without a huge test suite
Attachment #413394 -
Flags: review?(clouserw) → review+
Assignee | ||
Comment 4•15 years ago
|
||
r56476 | ddash@mozilla.com | 2009-11-19 12:56:54 -0800 (Thu, 19 Nov 2009) | 2 li [bug 529866] Reindexing platform correctly
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 5•15 years ago
|
||
Comment 9•15 years ago
|
||
(In reply to comment #8) > These were not pushed tonight. We found out tonight that fixes to some parts of search actually *are* independent, so this bug did go out tonight (re-verified on prod).
Target Milestone: 5.4 → 5.3.1
Comment 10•15 years ago
|
||
I pulled it back to 5.4 for the commit in comment 4 which I don't think went.
Comment 11•15 years ago
|
||
Many Thanks for all your work. My add-on is found on the live site again. It's fairly important because the download average had dropped to half during the bug.
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•