529912 - <setting/> should provide type="integer"

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sonny Piers [:sonny]]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091109 Ubuntu/9.10 (karmic) Firefox/3.5.5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.b3pre) Gecko/20091109 Namoraka/3.6b3pre Fennec/1.0b5

<setting/> should provide type="integer" because actually there is no way to manipulate integer pref.

Reproducible: Always

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Actually we support numeric textbox with inputype="number" on setting-string from setting.xml. (http://mxr.mozilla.org/mobile-browser/source/chrome/content/bindings/setting.xml#204)

But the binding didn't fit well at all in fennec.

Madhava do you have an idea of the wanted style?  - this is the equivalent of https://developer.mozilla.org/en/XUL_Tutorial/Numeric_Controls.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #1)
> Actually we support numeric textbox with inputype="number" on setting-string
> from setting.xml.
> (http://mxr.mozilla.org/mobile-browser/source/chrome/content/bindings/setting.xml#204)

But that binding will save to a String pref, not an Integer pref
 
> But the binding didn't fit well at all in fennec.

Huh?

> Madhava do you have an idea of the wanted style?  - this is the equivalent of
> https://developer.mozilla.org/en/XUL_Tutorial/Numeric_Controls.

Why doesn't the current textbox-showing-a-number style work?

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Actual look of a numeric textbox

(In reply to comment #2)
> (In reply to comment #1)
> > Actually we support numeric textbox with inputype="number" on setting-string
> > from setting.xml.
> > (http://mxr.mozilla.org/mobile-browser/source/chrome/content/bindings/setting.xml#204)
> 
> But that binding will save to a String pref, not an Integer pref

true.

> 
> > But the binding didn't fit well at all in fennec.
> 
> Huh?

see the attached screenshot


> > Madhava do you have an idea of the wanted style?  - this is the equivalent of
> > https://developer.mozilla.org/en/XUL_Tutorial/Numeric_Controls.
> 
> Why doesn't the current textbox-showing-a-number style work?

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: screenshot

I'm currently working on a wip which made numberbox looks like that.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: wip

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: wip for hildon

sorry for the spam, i've forgot the image in the previous wip

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 415155 [details] [diff] [review]
Patch

We need to keep the number related attributes on the "string" type for doubles.

The new binding should only handle integers, so we should remove the "decimalplaces" attribute from the "int" type.

I'll make those changes and land.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed with changes and removed the test setting from browser.xul:
https://hg.mozilla.org/mobile-browser/rev/52a6eef433fc

Comment 10

[Aakash Desai [:aakashd]]

Is there a use case for this via an add-on or is this something that's being added in as a nice-to-have?

Comment 11

[Sonny Piers [:sonny]]

well, I have integer prefs for my add-on.