Closed
Bug 529933
Opened 15 years ago
Closed 12 years ago
[Mac] "File" toolbar button shows old folder after bug 491294
Categories
(Thunderbird :: Toolbars and Tabs, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 12.0
People
(Reporter: ts.bugzilla, Assigned: andreasn)
References
Details
Attachments
(2 files, 1 obsolete file)
109.48 KB,
image/png
|
Details | |
236.98 KB,
patch
|
andreasn
:
review+
andreasn
:
ui-review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2b3) Gecko/20091115 Firefox/3.6b3 Build Identifier: Bug 491294 brought updated Leopard-style folder icons for the folder pane, the compose window toolbar and probably some more. But the "File..." button on the main toolbar was omitted. Reproducible: Always
Reporter | ||
Updated•15 years ago
|
Flags: blocking-thunderbird3?
Assignee | ||
Comment 1•15 years ago
|
||
Attachment #413580 -
Flags: ui-review?(clarkbw)
Assignee | ||
Comment 2•15 years ago
|
||
to ease ui review
Comment 3•15 years ago
|
||
Not blocking on this, though we could potentially take it for a point release of 3.0 (undecided as of yet).
Flags: blocking-thunderbird3? → blocking-thunderbird3-
Updated•15 years ago
|
Attachment #413580 -
Flags: ui-review?(clarkbw) → ui-review+
Comment 4•15 years ago
|
||
Comment on attachment 413580 [details] [diff] [review] new folder icons for main toolbar and compose window looks good from the screenshots, thanks andreas!
Comment on attachment 413580 [details] [diff] [review] new folder icons for main toolbar and compose window Confirming per the comments. Was this patch integrated or not?
Attachment #413580 -
Flags: superreview?(mbanner)
Comment 6•13 years ago
|
||
Comment on attachment 413580 [details] [diff] [review] new folder icons for main toolbar and compose window Please don't ask by requesting review, just ask the author of the patch (making sure they are cc'ed or assigned), if it is still wanted.
Attachment #413580 -
Flags: superreview?(mbanner)
Assignee | ||
Comment 7•13 years ago
|
||
Comment on attachment 413580 [details] [diff] [review] new folder icons for main toolbar and compose window Totally forgot about this bug. Asking bwinton for review here.
Attachment #413580 -
Flags: review?(bwinton)
Comment 8•13 years ago
|
||
Comment on attachment 413580 [details] [diff] [review] new folder icons for main toolbar and compose window Review of attachment 413580 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me, although I admit I haven't tested out the patch on a recent build. I'm going to say r=me, but I would like to see a link to a try-server build that I could run a quick check on. :)
Attachment #413580 -
Flags: review?(bwinton) → review+
Assignee | ||
Comment 9•13 years ago
|
||
Here you go! http://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/nisses.mail@home.se-31f8aa7f478e/try-comm-central-macosx-debug/
Comment 10•13 years ago
|
||
(In reply to Andreas Nilsson (:andreasn) from comment #9) > Here you go! > > http://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/nisses. > mail@home.se-31f8aa7f478e/try-comm-central-macosx-debug/
Updated•13 years ago
|
Assignee: nobody → nisses.mail
Status: NEW → ASSIGNED
Comment 11•12 years ago
|
||
Why is this not checked-in ?
Comment 12•12 years ago
|
||
checkin-needed missing?
Comment 13•12 years ago
|
||
I suspect forgotten or was waiting for Blake to test. In any case, I suspect it needs a new patch (andreasn?)
Assignee | ||
Comment 14•12 years ago
|
||
Yup, graphics needs to be slightly updated, since we got at least one new icon on the toolbar.
Assignee | ||
Comment 15•12 years ago
|
||
new patch. Carrying over review and ui-review.
Attachment #413580 -
Attachment is obsolete: true
Attachment #591068 -
Flags: ui-review+
Attachment #591068 -
Flags: review+
Updated•12 years ago
|
Attachment #591068 -
Attachment is patch: true
Comment 17•12 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/feb02f829940
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
You need to log in
before you can comment on or make changes to this bug.
Description
•