Closed Bug 53011 Opened 24 years ago Closed 24 years ago

United Nations homepage messed up

Categories

(Core :: DOM: HTML Parser, defect, P1)

Product:
Core
Component:
DOM: HTML Parser
Platform:
x86
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: spam, Assigned: rickg)

References

(
URL
)

Details

(Whiteboard: [RTM++] fix in hand (1 liner)) 

2000091606 M18 Linux

http://www.un.org/english/ lays out wrong, images missing, comments showing,
columns wrong. The js mouseover menus appear in one long column instead of on
each side of the logo. Since one now has to scroll far down to see all links,
the explanation for them becomes "invisible", because it displays out of reach,
near top of page (where it should display).
--> layout, seeing also on win32.

<!-----------------------------------------------
This is the start of bottom utility Navigation bar
------------------------------------------------->

I assume that is causing the problems, as the text is shown in win32.
OS: Linux → All
possibly because this page declares a HTML 4 Strict DTD and doens't even come
close to validating?

over to Parser.
Assignee: asa → rickg
Component: Browser-General → Parser
QA Contact: doronr → janc
The strictDTD is disabled. I'll take a quick look to see if this has *anything*
to do with the parsing engine.
Status: NEW → ASSIGNED
The problem is that comments are being parsed in "strictmode" on this page with 
a strict Doctype. I neglected to disable this. It's a one line change. 
Requestion RTM++.
Keywords: rtm
Whiteboard: [rtm+]
This is related to turning off the strictDTD. It's absolutely essential that it 
go in for RTM, or we'll break on lots of badly formed pages.
Whiteboard: [rtm+] → [RTM+] fix in hand (1 liner)
marking ++ for review.
Whiteboard: [RTM+] fix in hand (1 liner) → [RTM++] fix in hand (1 liner)
Severity: normal → major
Priority: P3 → P1
Target Milestone: --- → M18
Whiteboard: [RTM++] fix in hand (1 liner) → [RTM+] fix in hand (1 liner)
PDT thought strict dtd was already disabled.  What's the issue now?  Cc'ing
Vidur and Harish.  Please get this bug reviewed and super reviewed.
Whiteboard: [RTM+] fix in hand (1 liner) → [RTM+ needinfo] fix in hand (1 liner)
This involves strict comment parsing ( doesn't happen in the DTD ) in 
HTMLTokenizer. Yes, this should be disabled too.
Whiteboard: [RTM+ needinfo] fix in hand (1 liner) → [RTM+ need info] fix in hand (1 liner)
Here's the patch:

Index: nsHTMLTokens.cpp
===================================================================
RCS file: /cvsroot/mozilla/htmlparser/src/nsHTMLTokens.cpp,v
retrieving revision 3.173
diff -r3.173 nsHTMLTokens.cpp
999a1000,1001
>
> #if 0 //set to 1 if you want strict comments...  bug 53011...
1002a1005,1006
> #endif
>
Whiteboard: [RTM+ need info] fix in hand (1 liner) → [RTM+] fix in hand (1 liner)
PDT marking [rtm need info] since it appears that the patch hasn't been
code-reviewed yet.
Whiteboard: [RTM+] fix in hand (1 liner) → [RTM need info] fix in hand (1 liner)
The code has been reviewed and superreviewed by buster.
Whiteboard: [RTM need info] fix in hand (1 liner) → [RTM+] fix in hand (1 liner)
PDT marking back to need info. Reviewer and super reviewer must be distinct.
Whiteboard: [RTM+] fix in hand (1 liner) → [RTM need info] fix in hand (1 liner)
Ok -- reviewed by Attinasi.
Whiteboard: [RTM need info] fix in hand (1 liner) → [RTM+] fix in hand (1 liner)
pdt:  ++.
Whiteboard: [RTM+] fix in hand (1 liner) → [RTM++] fix in hand (1 liner)
Fixed by preventing strict comment handling, period.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
SEA 2000101212 linux
The UN pages now look good again - fix fixed everything reported in this bug :)

verified per reporter comments
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.