530931 - Maemo shouldn't use the true DPI

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Trying to use the true DPI on Maemo (bug 449283) has created some problems that really can't be worked around (bug 527750). The best solution is to _not_ use the true DPI in the platform and to instead use the reported GTK DPI (96 in this case). The result will allow fonts to render in an appropriate size, in relation to the surrounding elements. The fonts will not render at the correct physical size, but that isn't desired anyway.

I have a patch that restores the previous DPI algorithm, but keeps the refactoring completed in bug 449283. The patch working it's way through the Try server. If it works out, I'll attach it for review.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

blocking a fennec blocker (bug 527750)

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch reverts the DPI setting to the previous "whatever gtk says" method. It removes the concept of the PlatformDPI, which was only used because the system fonts wanted to be based off of 96 DPI, not the device DPI.

The patch removes the caching of the MaemoClassic flag from gfxPatformGTK and puts it in nsLookAndFeel, where it is used anyway.

The patch does not completely revert the code refactoring that was done to cleanup the DPI access methods.

Using this patch (which passes try server) and a tweaked Fennec chrome UI stylesheet, the font size issue found in bug 527750 fixed.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed to m-c:
http://hg.mozilla.org/mozilla-central/rev/5467b361e6fa

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed to m-192:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/83c49eb836fe